qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, qemu-block@nongnu.org
Subject: [Qemu-devel] [PATCH 06/10] qemu-iotests: do not include common.rc in "check"
Date: Tue, 12 Sep 2017 16:44:55 +0200	[thread overview]
Message-ID: <20170912144459.11359-7-pbonzini@redhat.com> (raw)
In-Reply-To: <20170912144459.11359-1-pbonzini@redhat.com>

It only provides functions used by the test programs.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
 tests/qemu-iotests/check     |  6 ------
 tests/qemu-iotests/common.rc | 13 +++++--------
 2 files changed, 5 insertions(+), 14 deletions(-)

diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
index b7c54390d3..4cb5b05908 100755
--- a/tests/qemu-iotests/check
+++ b/tests/qemu-iotests/check
@@ -72,12 +72,6 @@ then
     _init_error "failed to source common.config"
 fi
 
-# we need common.rc
-if ! . "$source_iotests/common.rc"
-then
-    _init_error "failed to source common.rc"
-fi
-
 # we need common
 . "$source_iotests/common"
 
diff --git a/tests/qemu-iotests/common.rc b/tests/qemu-iotests/common.rc
index e7f74b4dbd..20f6821a69 100644
--- a/tests/qemu-iotests/common.rc
+++ b/tests/qemu-iotests/common.rc
@@ -40,14 +40,11 @@ poke_file()
     printf "$3" | dd "of=$1" bs=1 "seek=$2" conv=notrunc &>/dev/null
 }
 
-# we need common.config
-if [ "$iam" != "check" ]
-then
-    if ! . ./common.config
-        then
-        echo "$iam: failed to source common.config"
-        exit 1
-    fi
+
+if ! . ./common.config
+    then
+    echo "$iam: failed to source common.config"
+    exit 1
 fi
 
 _qemu_wrapper()
-- 
2.13.5

  parent reply	other threads:[~2017-09-12 14:45 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-12 14:44 [Qemu-devel] [PATCH v2 00/10] cleanup qemu-iotests Paolo Bonzini
2017-09-12 14:44 ` [Qemu-devel] [PATCH 01/10] qemu-iotests: remove dead code Paolo Bonzini
2017-09-12 20:34   ` Eric Blake
2017-09-12 14:44 ` [Qemu-devel] [PATCH 02/10] qemu-iotests: get rid of AWK_PROG Paolo Bonzini
2017-09-12 16:30   ` Philippe Mathieu-Daudé
2017-09-12 16:36     ` Paolo Bonzini
2017-09-12 20:45   ` Eric Blake
2017-09-12 14:44 ` [Qemu-devel] [PATCH 03/10] qemu-iotests: move "check" code out of common.rc Paolo Bonzini
2017-09-12 21:03   ` Eric Blake
2017-09-12 14:44 ` [Qemu-devel] [PATCH 04/10] qemu-iotests: cleanup and fix search for programs Paolo Bonzini
2017-09-12 21:11   ` Eric Blake
2017-09-12 21:26     ` Paolo Bonzini
2017-09-12 21:34       ` Eric Blake
2017-09-12 14:44 ` [Qemu-devel] [PATCH 05/10] qemu-iotests: limit non-_PROG-suffixed variables to common.rc Paolo Bonzini
2017-09-12 21:15   ` Eric Blake
2017-09-12 14:44 ` Paolo Bonzini [this message]
2017-09-12 21:16   ` [Qemu-devel] [PATCH 06/10] qemu-iotests: do not include common.rc in "check" Eric Blake
2017-09-12 14:44 ` [Qemu-devel] [PATCH 07/10] qemu-iotests: disintegrate more parts of common.config Paolo Bonzini
2017-09-12 21:25   ` Eric Blake
2017-09-12 14:44 ` [Qemu-devel] [PATCH 08/10] qemu-iotests: fix uninitialized variable Paolo Bonzini
2017-09-12 21:30   ` Eric Blake
2017-09-12 14:44 ` [Qemu-devel] [PATCH 09/10] qemu-iotests: get rid of $iam Paolo Bonzini
2017-09-12 21:31   ` Eric Blake
2017-09-12 14:44 ` [Qemu-devel] [PATCH 10/10] qemu-iotests: merge "check" and "common" Paolo Bonzini
2017-09-12 21:34   ` Eric Blake
2017-09-13  6:47 ` [Qemu-devel] [PATCH v2 00/10] cleanup qemu-iotests Thomas Huth
2017-09-13  7:59   ` Fam Zheng
2017-09-13 22:06     ` Paolo Bonzini
2017-09-13 22:14       ` Eric Blake
2017-10-02 12:32 ` [Qemu-devel] [Qemu-block] " Paolo Bonzini
2017-10-04 16:26 ` [Qemu-devel] " Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170912144459.11359-7-pbonzini@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).