From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45090) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ds0uk-0000fo-Qb for qemu-devel@nongnu.org; Wed, 13 Sep 2017 02:12:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ds0uh-0005Er-Mb for qemu-devel@nongnu.org; Wed, 13 Sep 2017 02:12:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41446) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ds0uh-0005Bb-Ft for qemu-devel@nongnu.org; Wed, 13 Sep 2017 02:12:43 -0400 Date: Wed, 13 Sep 2017 14:12:37 +0800 From: Peter Xu Message-ID: <20170913061237.GD3617@pxdev.xzpeter.org> References: <20170911132627.9505-1-cohuck@redhat.com> <20170912033333.GA29091@pxdev.xzpeter.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] dump: do not dump non-existent guest memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau Cc: Cornelia Huck , Laurent Vivier , QEMU , "Dr. David Alan Gilbert" On Tue, Sep 12, 2017 at 12:17:51PM +0200, Marc-Andr=C3=A9 Lureau wrote: > Hi Peter >=20 > On Tue, Sep 12, 2017 at 5:33 AM, Peter Xu wrote: > > On Mon, Sep 11, 2017 at 03:26:27PM +0200, Cornelia Huck wrote: > >> It does not really make sense to dump memory that is not there. > >> > >> Moreover, that fixes a segmentation fault when calling dump-guest-me= mory > >> with no filter for a machine with no memory defined. > >> > >> New behaviour is: > >> > >> (qemu) dump-guest-memory /dev/null > >> dump: no guest memory to dump > >> (qemu) dump-guest-memory /dev/null 0 4096 > >> dump: no guest memory to dump > >> > >> Signed-off-by: Cornelia Huck > >> --- > >> > >> Another unmaintained file. Joy. cc:ing some more-or-less random folk= s. > > > > I thought Marc-Andr=C3=A9 had proposed to be the maintainer? But inde= ed I > > didn't see the line in maintainer file. > > > > Anyway, if anyone think I am ok to maintain this single file > > (considering that I haven't posted patches on it for 2 years, and I > > haven't been working on any kind of maintainer job), please let me > > know. I'm glad to start with it (or with Marc-Andr=C3=A9). > > >=20 > That would be great! > thanks Let me try to draft a maintainer file change for this, to see whether there are objections. Thanks! --=20 Peter Xu