From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Alexander Graf <agraf@suse.de>, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PULL 4/4] console: add question-mark escape operator
Date: Wed, 13 Sep 2017 10:40:51 +0200 [thread overview]
Message-ID: <20170913084051.21378-5-kraxel@redhat.com> (raw)
In-Reply-To: <20170913084051.21378-1-kraxel@redhat.com>
From: Alexander Graf <agraf@suse.de>
Some termcaps (found using SLES11SP1) use [? sequences. According to man
console_codes (http://linux.die.net/man/4/console_codes) the question mark
is a nop and should simply be ignored.
This patch does exactly that, rendering screen output readable when
outputting guest serial consoles to the graphical console emulator.
Signed-off-by: Alexander Graf <agraf@suse.de>
Message-id: 20170829113818.42482-1-agraf@suse.de
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
ui/console.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ui/console.c b/ui/console.c
index f0292d7820..b82c27960a 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -880,8 +880,9 @@ static void console_putchar(QemuConsole *s, int ch)
} else {
if (s->nb_esc_params < MAX_ESC_PARAMS)
s->nb_esc_params++;
- if (ch == ';')
+ if (ch == ';' || ch == '?') {
break;
+ }
trace_console_putchar_csi(s->esc_params[0], s->esc_params[1],
ch, s->nb_esc_params);
s->state = TTY_STATE_NORM;
--
2.9.3
next prev parent reply other threads:[~2017-09-13 8:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 8:40 [Qemu-devel] [PULL 0/4] Ui 20170913 patches Gerd Hoffmann
2017-09-13 8:40 ` [Qemu-devel] [PULL 1/4] pixman: drop submodule Gerd Hoffmann
2017-09-13 8:40 ` [Qemu-devel] [PULL 2/4] pixman: drop configure switches Gerd Hoffmann
2017-09-13 8:40 ` [Qemu-devel] [PULL 3/4] console: fix dpy_gfx_replace_surface assert Gerd Hoffmann
2017-09-13 8:40 ` Gerd Hoffmann [this message]
2017-09-14 14:47 ` [Qemu-devel] [PULL 0/4] Ui 20170913 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170913084051.21378-5-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=agraf@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).