From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PULL 3/4] usb: drop HOST_USB
Date: Wed, 13 Sep 2017 11:32:14 +0200 [thread overview]
Message-ID: <20170913093215.10043-4-kraxel@redhat.com> (raw)
In-Reply-To: <20170913093215.10043-1-kraxel@redhat.com>
Nowdays we use libusb for usb-host, so we don't have different code
for linux vs. bsd any more. So there is little reason to have the
HOST_USB variable, we can just write things directly into the Makefile
and avoid a pointless indirection.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Fam Zheng <famz@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-id: 20170908111217.21985-2-kraxel@redhat.com
---
configure | 7 -------
hw/usb/Makefile.objs | 6 +++++-
2 files changed, 5 insertions(+), 8 deletions(-)
diff --git a/configure b/configure
index fd7e3a5e81..5367260c80 100755
--- a/configure
+++ b/configure
@@ -5967,13 +5967,6 @@ if test "$live_block_migration" = "yes" ; then
echo "CONFIG_LIVE_BLOCK_MIGRATION=y" >> $config_host_mak
fi
-# USB host support
-if test "$libusb" = "yes"; then
- echo "HOST_USB=libusb legacy" >> $config_host_mak
-else
- echo "HOST_USB=stub" >> $config_host_mak
-fi
-
# TPM passthrough support?
if test "$tpm" = "yes"; then
echo 'CONFIG_TPM=$(CONFIG_SOFTMMU)' >> $config_host_mak
diff --git a/hw/usb/Makefile.objs b/hw/usb/Makefile.objs
index 97f1c4561a..a43ebbc17f 100644
--- a/hw/usb/Makefile.objs
+++ b/hw/usb/Makefile.objs
@@ -38,7 +38,11 @@ endif
common-obj-$(CONFIG_USB_REDIR) += redirect.o quirks.o
# usb pass-through
-common-obj-y += $(patsubst %,host-%.o,$(HOST_USB))
+ifeq ($(CONFIG_LIBUSB),y)
+common-obj-y += host-libusb.o host-legacy.o
+else
+common-obj-y += host-stub.o
+endif
ifeq ($(CONFIG_USB_LIBUSB),y)
common-obj-$(CONFIG_XEN) += xen-usb.o
--
2.9.3
next prev parent reply other threads:[~2017-09-13 9:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 9:32 [Qemu-devel] [PULL 0/4] Usb 20170913 patches Gerd Hoffmann
2017-09-13 9:32 ` [Qemu-devel] [PULL 1/4] xhci: Avoid DMA when ERSTBA is set to zero Gerd Hoffmann
2017-09-13 9:32 ` [Qemu-devel] [PULL 2/4] MAINTAINERS: add missing USB entry Gerd Hoffmann
2017-09-13 9:32 ` Gerd Hoffmann [this message]
2017-09-13 9:32 ` [Qemu-devel] [PULL 4/4] usb: only build usb-host with CONFIG_USB=y Gerd Hoffmann
2017-09-14 15:32 ` [Qemu-devel] [PULL 0/4] Usb 20170913 patches Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170913093215.10043-4-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).