qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: dgilbert@redhat.com, lvivier@redhat.com, peterx@redhat.com
Subject: [Qemu-devel] [PATCH v8 02/20] migration: Teach it about G_SOURCE_REMOVE
Date: Wed, 13 Sep 2017 12:59:35 +0200	[thread overview]
Message-ID: <20170913105953.13760-3-quintela@redhat.com> (raw)
In-Reply-To: <20170913105953.13760-1-quintela@redhat.com>

As this is defined on glib 2.32, add compatibility macros for older glibs.

Signed-off-by: Juan Quintela <quintela@redhat.com>
Reviewed-by: Daniel P. Berrange <berrange@redhat.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
---
 include/glib-compat.h | 2 ++
 migration/exec.c      | 2 +-
 migration/fd.c        | 2 +-
 migration/socket.c    | 2 +-
 4 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/include/glib-compat.h b/include/glib-compat.h
index fcffcd3f07..e15aca2d40 100644
--- a/include/glib-compat.h
+++ b/include/glib-compat.h
@@ -223,6 +223,8 @@ static inline gboolean g_hash_table_contains(GHashTable *hash_table,
 {
     return g_hash_table_lookup_extended(hash_table, key, NULL, NULL);
 }
+#define G_SOURCE_CONTINUE TRUE
+#define G_SOURCE_REMOVE FALSE
 #endif
 
 #ifndef g_assert_true
diff --git a/migration/exec.c b/migration/exec.c
index 08b599e0e2..f3be1baf2e 100644
--- a/migration/exec.c
+++ b/migration/exec.c
@@ -49,7 +49,7 @@ static gboolean exec_accept_incoming_migration(QIOChannel *ioc,
 {
     migration_channel_process_incoming(ioc);
     object_unref(OBJECT(ioc));
-    return FALSE; /* unregister */
+    return G_SOURCE_REMOVE;
 }
 
 void exec_start_incoming_migration(const char *command, Error **errp)
diff --git a/migration/fd.c b/migration/fd.c
index 30f5258a6a..30de4b9847 100644
--- a/migration/fd.c
+++ b/migration/fd.c
@@ -49,7 +49,7 @@ static gboolean fd_accept_incoming_migration(QIOChannel *ioc,
 {
     migration_channel_process_incoming(ioc);
     object_unref(OBJECT(ioc));
-    return FALSE; /* unregister */
+    return G_SOURCE_REMOVE;
 }
 
 void fd_start_incoming_migration(const char *infd, Error **errp)
diff --git a/migration/socket.c b/migration/socket.c
index 757d3821a1..b02d37d7a3 100644
--- a/migration/socket.c
+++ b/migration/socket.c
@@ -154,7 +154,7 @@ static gboolean socket_accept_incoming_migration(QIOChannel *ioc,
 out:
     /* Close listening socket as its no longer needed */
     qio_channel_close(ioc, NULL);
-    return FALSE; /* unregister */
+    return G_SOURCE_REMOVE;
 }
 
 
-- 
2.13.5

  parent reply	other threads:[~2017-09-13 11:00 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-13 10:59 [Qemu-devel] [PATCH v8 00/20] Multifd Juan Quintela
2017-09-13 10:59 ` [Qemu-devel] [PATCH v8 01/20] migration: Create migration_ioc_process_incoming() Juan Quintela
2017-09-13 10:59 ` Juan Quintela [this message]
2017-09-13 10:59 ` [Qemu-devel] [PATCH v8 03/20] migration: Add comments to channel functions Juan Quintela
2017-09-13 10:59 ` [Qemu-devel] [PATCH v8 04/20] migration: Create migration_has_all_channels Juan Quintela
2017-09-13 10:59 ` [Qemu-devel] [PATCH v8 05/20] migration: Improve migration thread error handling Juan Quintela
2017-09-18 16:34   ` Dr. David Alan Gilbert
2017-09-13 10:59 ` [Qemu-devel] [PATCH v8 06/20] migration: Make migrate_fd_error() the owner of the Error Juan Quintela
2017-09-13 10:59 ` [Qemu-devel] [PATCH v8 07/20] migration: Add multifd capability Juan Quintela
2017-09-13 10:59 ` [Qemu-devel] [PATCH v8 08/20] migration: Create x-multifd-channels parameter Juan Quintela
2017-09-13 10:59 ` [Qemu-devel] [PATCH v8 09/20] migration: Create x-multifd-page-count parameter Juan Quintela
2017-09-13 10:59 ` [Qemu-devel] [PATCH v8 10/20] migration: Create multifd migration threads Juan Quintela
2017-09-13 10:59 ` [Qemu-devel] [PATCH v8 11/20] migration: Split migration_fd_process_incoming Juan Quintela
2017-09-13 10:59 ` [Qemu-devel] [PATCH v8 12/20] migration: Start of multiple fd work Juan Quintela
2017-09-13 11:35   ` Daniel P. Berrange
2017-09-13 11:44   ` Daniel P. Berrange
2017-09-13 10:59 ` [Qemu-devel] [PATCH v8 13/20] migration: Create ram_multifd_page Juan Quintela
2017-09-13 10:59 ` [Qemu-devel] [PATCH v8 14/20] migration: Really use multiple pages at a time Juan Quintela
2017-09-13 10:59 ` [Qemu-devel] [PATCH v8 15/20] migration: Send the fd number which we are going to use for this page Juan Quintela
2017-09-13 10:59 ` [Qemu-devel] [PATCH v8 16/20] migration: Create thread infrastructure for multifd recv side Juan Quintela
2017-09-13 11:42   ` Daniel P. Berrange
2017-09-13 10:59 ` [Qemu-devel] [PATCH v8 17/20] migration: Test new fd infrastructure Juan Quintela
2017-09-13 10:59 ` [Qemu-devel] [PATCH v8 18/20] migration: Rename initial_bytes Juan Quintela
2017-09-13 10:59 ` [Qemu-devel] [PATCH v8 19/20] migration: Transfer pages over new channels Juan Quintela
2017-09-13 10:59 ` [Qemu-devel] [PATCH v8 20/20] migration: Flush receive queue Juan Quintela

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170913105953.13760-3-quintela@redhat.com \
    --to=quintela@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).