qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: Richard Henderson <richard.henderson@linaro.org>,
	thuth@redhat.com, cohuck@redhat.com, david@redhat.com,
	borntraeger@de.ibm.com, Alexander Graf <agraf@suse.de>,
	Eduardo Habkost <ehabkost@redhat.com>,
	Matthew Rosato <mjrosato@linux.vnet.ibm.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	Markus Armbruster <armbru@redhat.com>,
	Igor Mammedov <imammedo@redhat.com>
Subject: [Qemu-devel] [PATCH v5 09/22] target/s390x: use trigger_pgm_exception() in s390_cpu_handle_mmu_fault()
Date: Wed, 13 Sep 2017 15:24:04 +0200	[thread overview]
Message-ID: <20170913132417.24384-10-david@redhat.com> (raw)
In-Reply-To: <20170913132417.24384-1-david@redhat.com>

This looks cleaner. linux-user will not use the ilen field, so setting
it doesn't do any harm.

Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: David Hildenbrand <david@redhat.com>
---
 target/s390x/excp_helper.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/target/s390x/excp_helper.c b/target/s390x/excp_helper.c
index 361f970db3..14d3160e92 100644
--- a/target/s390x/excp_helper.c
+++ b/target/s390x/excp_helper.c
@@ -59,8 +59,7 @@ int s390_cpu_handle_mmu_fault(CPUState *cs, vaddr address,
 {
     S390CPU *cpu = S390_CPU(cs);
 
-    cs->exception_index = EXCP_PGM;
-    cpu->env.int_pgm_code = PGM_ADDRESSING;
+    trigger_pgm_exception(&cpu->env, PGM_ADDRESSING, ILEN_AUTO);
     /* On real machines this value is dropped into LowMem.  Since this
        is userland, simply put this someplace that cpu_loop can find it.  */
     cpu->env.__excp_addr = address;
-- 
2.13.5

  parent reply	other threads:[~2017-09-13 13:25 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-13 13:23 [Qemu-devel] [PATCH v5 00/22] s390x cleanups and CPU hotplug via device_add David Hildenbrand
2017-09-13 13:23 ` [Qemu-devel] [PATCH v5 01/22] exec, dump, i386, ppc, s390x: don't include exec/cpu-all.h explicitly David Hildenbrand
2017-09-13 13:23 ` [Qemu-devel] [PATCH v5 02/22] cpu: drop old comments describing members David Hildenbrand
2017-09-13 13:23 ` [Qemu-devel] [PATCH v5 03/22] s390x: get rid of s390-virtio.c David Hildenbrand
2017-09-13 16:34   ` David Hildenbrand
2017-09-13 16:54     ` Cornelia Huck
2017-09-13 13:23 ` [Qemu-devel] [PATCH v5 04/22] s390x: rename s390-virtio.h to s390-virtio-hcall.h David Hildenbrand
2017-09-13 13:24 ` [Qemu-devel] [PATCH v5 05/22] s390x: move s390_virtio_hypercall() " David Hildenbrand
2017-09-13 13:24 ` [Qemu-devel] [PATCH v5 06/22] s390x: move subsystem_reset() to s390-virtio-ccw.h David Hildenbrand
2017-09-13 13:24 ` [Qemu-devel] [PATCH v5 07/22] target/s390x: move some s390x typedefs to cpu-qom.h David Hildenbrand
2017-09-13 14:27   ` Thomas Huth
2017-09-13 14:44     ` David Hildenbrand
2017-09-13 15:04       ` Thomas Huth
2017-09-13 13:24 ` [Qemu-devel] [PATCH v5 08/22] s390x: move sclp_service_call() to sclp.h David Hildenbrand
2017-09-13 14:29   ` Thomas Huth
2017-09-13 14:42     ` David Hildenbrand
2017-09-13 15:21     ` Cornelia Huck
2017-09-13 15:23       ` David Hildenbrand
2017-09-13 13:24 ` David Hildenbrand [this message]
2017-09-13 13:24 ` [Qemu-devel] [PATCH v5 10/22] target/s390x: use program_interrupt() in per_check_exception() David Hildenbrand
2017-09-13 13:24 ` [Qemu-devel] [PATCH v5 11/22] s390x: allow only 1 CPU with TCG David Hildenbrand
2017-09-13 14:06   ` Igor Mammedov
2017-09-13 16:13   ` Alex Bennée
2017-09-13 16:25     ` David Hildenbrand
2017-09-15 13:17       ` Alex Bennée
2017-09-15 13:36         ` David Hildenbrand
2017-09-13 13:24 ` [Qemu-devel] [PATCH v5 12/22] target/s390x: set cpu->id for linux user when realizing David Hildenbrand
2017-09-13 13:24 ` [Qemu-devel] [PATCH v5 13/22] target/s390x: use "core-id" for cpu number/address/id handling David Hildenbrand
2017-09-13 13:24 ` [Qemu-devel] [PATCH v5 14/22] target/s390x: rename next_cpu_id to next_core_id David Hildenbrand
2017-09-13 13:24 ` [Qemu-devel] [PATCH v5 15/22] s390x: print CPU definitions in sorted order David Hildenbrand
2017-09-13 13:24 ` [Qemu-devel] [PATCH v5 16/22] s390x: allow cpu hotplug via device_add David Hildenbrand
2017-09-28  6:01   ` Thomas Huth
2017-09-28 13:00     ` David Hildenbrand
2017-09-28 13:36     ` David Hildenbrand
2017-09-13 13:24 ` [Qemu-devel] [PATCH v5 17/22] s390x: CPU hot unplug via device_del cannot work for now David Hildenbrand
2017-09-13 15:45   ` Cornelia Huck
2017-09-13 13:24 ` [Qemu-devel] [PATCH v5 18/22] s390x: implement query-hotpluggable-cpus David Hildenbrand
2017-09-13 14:42   ` Igor Mammedov
2017-09-13 15:49   ` Cornelia Huck
2017-09-13 15:50     ` David Hildenbrand
2017-10-02  7:46   ` Markus Armbruster
2017-10-04  8:04     ` Cornelia Huck
2017-10-04 12:42       ` Markus Armbruster
2017-10-04 13:09         ` Cornelia Huck
2017-10-06 17:17           ` Markus Armbruster
2017-10-09 10:31             ` Marc-André Lureau
2017-09-13 13:24 ` [Qemu-devel] [PATCH v5 19/22] s390x: get rid of cpu_states and use possible_cpus instead David Hildenbrand
2017-09-13 14:45   ` Igor Mammedov
2017-09-13 13:24 ` [Qemu-devel] [PATCH v5 20/22] s390x: get rid of cpu_s390x_create() David Hildenbrand
2017-09-13 13:24 ` [Qemu-devel] [PATCH v5 21/22] s390x: generate sclp cpu information from possible_cpus David Hildenbrand
2017-09-13 13:24 ` [Qemu-devel] [PATCH v5 22/22] s390x: allow CPU hotplug in random core-id order David Hildenbrand
2017-09-13 14:46   ` Igor Mammedov
2017-09-13 16:58 ` [Qemu-devel] [PATCH v5 00/22] s390x cleanups and CPU hotplug via device_add Cornelia Huck
2017-10-02  7:47   ` Markus Armbruster
2017-10-04  8:05     ` Cornelia Huck
2017-10-20 15:45 ` David Hildenbrand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170913132417.24384-10-david@redhat.com \
    --to=david@redhat.com \
    --cc=agraf@suse.de \
    --cc=armbru@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=cohuck@redhat.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=mjrosato@linux.vnet.ibm.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).