Re: [Qemu-devel] [PATCH v3 1/3] hmp: fix "dump-quest-memory" segfault (ppc)

["Dr. David Alan Gilbert" <dgilbert@redhat.com>]

* Laurent Vivier (lvivier@redhat.com) wrote:
> On 13/09/2017 15:19, Dr. David Alan Gilbert wrote:
> > * Laurent Vivier (lvivier@redhat.com) wrote:
> >> On 13/09/2017 14:44, Dr. David Alan Gilbert wrote:
> >>> * David Gibson (david@gibson.dropbear.id.au) wrote:
> >>>> On Tue, Sep 12, 2017 at 04:01:47PM +0200, Laurent Vivier wrote:
> >>>>> Running QEMU with
> >>>>>     qemu-system-ppc64 -M none -nographic -m 256
> >>>>> and executing
> >>>>>     dump-guest-memory /dev/null 0 8192
> >>>>> results in segfault
> >>>>>
> >>>>> Fix by checking if we have CPU, and exit with
> >>>>> error if there is no CPU:
> >>>>>
> >>>>>     (qemu) dump-guest-memory /dev/null
> >>>>>     this feature or command is not currently supported
> >>>>>
> >>>>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> >>>>
> >>>> Applied to ppc-for-2.11.  I'm not really sure what to do with the rest
> >>>> of the series though.
> >>>
> >>> I can take the whole set through HMP.
> >>
> >> Could you update the comment in last patch as asked by Cornelia?
> >> (PATCH v3 3/3] tests/hmp: test "none" machine with memory)
> > 
> > Sure, do we understand what the error that patchew caught was?
> 
> We need the fix from Cornelia, otherwise the new test fails.
> 
> Do you want I resend the series including the fix from Cornelia to be
> sure patchew works?

Yes, that's best because I think you're saying we need to put
Cornelia's fix in before your 3/3 to ensure it's bisectable.

Dave

> Thanks,
> Laurent
--
Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK