From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45885) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ds7ub-0005QX-ID for qemu-devel@nongnu.org; Wed, 13 Sep 2017 09:41:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ds7uX-0008Be-Kr for qemu-devel@nongnu.org; Wed, 13 Sep 2017 09:41:05 -0400 Date: Wed, 13 Sep 2017 14:40:50 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20170913134050.GE2096@work-vm> References: <20170912140149.7692-1-lvivier@redhat.com> <20170912140149.7692-2-lvivier@redhat.com> <20170913053533.GF7550@umbus.fritz.box> <20170913124456.GB2096@work-vm> <770fc286-a566-920a-9aba-16c3b5264806@redhat.com> <20170913131948.GD2096@work-vm> <5accd02c-f116-22ef-99ef-1ddd9e58fc21@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5accd02c-f116-22ef-99ef-1ddd9e58fc21@redhat.com> Subject: Re: [Qemu-devel] [PATCH v3 1/3] hmp: fix "dump-quest-memory" segfault (ppc) List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: David Gibson , qemu-devel@nongnu.org, "Daniel P . Berrange" , Cornelia Huck , Thomas Huth , qemu-arm@nongnu.org, qemu-ppc@nongnu.org, Peter Maydell , Greg Kurz * Laurent Vivier (lvivier@redhat.com) wrote: > On 13/09/2017 15:19, Dr. David Alan Gilbert wrote: > > * Laurent Vivier (lvivier@redhat.com) wrote: > >> On 13/09/2017 14:44, Dr. David Alan Gilbert wrote: > >>> * David Gibson (david@gibson.dropbear.id.au) wrote: > >>>> On Tue, Sep 12, 2017 at 04:01:47PM +0200, Laurent Vivier wrote: > >>>>> Running QEMU with > >>>>> qemu-system-ppc64 -M none -nographic -m 256 > >>>>> and executing > >>>>> dump-guest-memory /dev/null 0 8192 > >>>>> results in segfault > >>>>> > >>>>> Fix by checking if we have CPU, and exit with > >>>>> error if there is no CPU: > >>>>> > >>>>> (qemu) dump-guest-memory /dev/null > >>>>> this feature or command is not currently supported > >>>>> > >>>>> Signed-off-by: Laurent Vivier > >>>> > >>>> Applied to ppc-for-2.11. I'm not really sure what to do with the rest > >>>> of the series though. > >>> > >>> I can take the whole set through HMP. > >> > >> Could you update the comment in last patch as asked by Cornelia? > >> (PATCH v3 3/3] tests/hmp: test "none" machine with memory) > > > > Sure, do we understand what the error that patchew caught was? > > We need the fix from Cornelia, otherwise the new test fails. > > Do you want I resend the series including the fix from Cornelia to be > sure patchew works? Yes, that's best because I think you're saying we need to put Cornelia's fix in before your 3/3 to ensure it's bisectable. Dave > Thanks, > Laurent -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK