From: Cornelia Huck <cohuck@redhat.com>
To: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
Cc: David Gibson <david@gibson.dropbear.id.au>,
Laurent Vivier <lvivier@redhat.com>,
qemu-devel@nongnu.org,
"Daniel P . Berrange" <berrange@redhat.com>,
Thomas Huth <thuth@redhat.com>,
qemu-arm@nongnu.org, qemu-ppc@nongnu.org,
Peter Maydell <peter.maydell@linaro.org>,
Greg Kurz <groug@kaod.org>
Subject: Re: [Qemu-devel] [PATCH v3 1/3] hmp: fix "dump-quest-memory" segfault (ppc)
Date: Wed, 13 Sep 2017 14:48:25 +0200 [thread overview]
Message-ID: <20170913144825.48cad531.cohuck@redhat.com> (raw)
In-Reply-To: <20170913124456.GB2096@work-vm>
On Wed, 13 Sep 2017 13:44:57 +0100
"Dr. David Alan Gilbert" <dgilbert@redhat.com> wrote:
> * David Gibson (david@gibson.dropbear.id.au) wrote:
> > On Tue, Sep 12, 2017 at 04:01:47PM +0200, Laurent Vivier wrote:
> > > Running QEMU with
> > > qemu-system-ppc64 -M none -nographic -m 256
> > > and executing
> > > dump-guest-memory /dev/null 0 8192
> > > results in segfault
> > >
> > > Fix by checking if we have CPU, and exit with
> > > error if there is no CPU:
> > >
> > > (qemu) dump-guest-memory /dev/null
> > > this feature or command is not currently supported
> > >
> > > Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> >
> > Applied to ppc-for-2.11. I'm not really sure what to do with the rest
> > of the series though.
>
> I can take the whole set through HMP.
If you do so, you should probably take "dump: do not dump non-existent
guest memory" as well.
next prev parent reply other threads:[~2017-09-13 12:48 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-12 14:01 [Qemu-devel] [PATCH v3 0/3] hmp: fix "dump-quest-memory" segfault Laurent Vivier
2017-09-12 14:01 ` [Qemu-devel] [PATCH v3 1/3] hmp: fix "dump-quest-memory" segfault (ppc) Laurent Vivier
2017-09-12 14:10 ` Thomas Huth
2017-09-12 14:48 ` Greg Kurz
2017-09-13 5:35 ` David Gibson
2017-09-13 12:44 ` Dr. David Alan Gilbert
2017-09-13 12:48 ` Cornelia Huck [this message]
2017-09-13 12:49 ` Laurent Vivier
2017-09-13 13:19 ` Dr. David Alan Gilbert
2017-09-13 13:23 ` Laurent Vivier
2017-09-13 13:40 ` Dr. David Alan Gilbert
2017-09-13 12:54 ` David Gibson
2017-09-12 14:01 ` [Qemu-devel] [PATCH v3 2/3] hmp: fix "dump-quest-memory" segfault (arm) Laurent Vivier
2017-09-12 14:11 ` Thomas Huth
2017-09-12 14:50 ` Greg Kurz
2017-09-12 14:01 ` [Qemu-devel] [PATCH v3 3/3] tests/hmp: test "none" machine with memory Laurent Vivier
2017-09-12 14:13 ` Thomas Huth
2017-09-13 7:53 ` Cornelia Huck
2017-09-12 14:17 ` [Qemu-devel] [PATCH v3 0/3] hmp: fix "dump-quest-memory" segfault no-reply
2017-09-12 14:46 ` Greg Kurz
2017-09-12 14:51 ` Thomas Huth
2017-09-12 15:26 ` Greg Kurz
2017-09-12 15:36 ` Dr. David Alan Gilbert
2017-09-13 5:34 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170913144825.48cad531.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=berrange@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=dgilbert@redhat.com \
--cc=groug@kaod.org \
--cc=lvivier@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).