From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Fam Zheng <famz@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
John Snow <jsnow@redhat.com>
Subject: [Qemu-devel] [PATCH 01/18] block: Add BdrvDeletedStatus
Date: Wed, 13 Sep 2017 20:18:53 +0200 [thread overview]
Message-ID: <20170913181910.29688-2-mreitz@redhat.com> (raw)
In-Reply-To: <20170913181910.29688-1-mreitz@redhat.com>
Sometimes an operation may delete a BDS. It may then not be trivial to
determine this because the BDS object itself cannot be accessed
afterwards. With this patch, one can attach a BdrvDeletedStatus object
to a BDS which can be used to safely query whether the BDS still exists
even after it has been deleted.
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
include/block/block_int.h | 12 ++++++++++++
block.c | 6 ++++++
2 files changed, 18 insertions(+)
diff --git a/include/block/block_int.h b/include/block/block_int.h
index ba4c383393..eaeaad9428 100644
--- a/include/block/block_int.h
+++ b/include/block/block_int.h
@@ -498,6 +498,13 @@ typedef struct BdrvAioNotifier {
QLIST_ENTRY(BdrvAioNotifier) list;
} BdrvAioNotifier;
+typedef struct BdrvDeletedStatus {
+ /* Set to true by bdrv_delete() */
+ bool deleted;
+
+ QLIST_ENTRY(BdrvDeletedStatus) next;
+} BdrvDeletedStatus;
+
struct BdrvChildRole {
/* If true, bdrv_replace_node() doesn't change the node this BdrvChild
* points to. */
@@ -706,6 +713,11 @@ struct BlockDriverState {
/* Only read/written by whoever has set active_flush_req to true. */
unsigned int flushed_gen; /* Flushed write generation */
+
+ /* When bdrv_delete() is invoked, it will walk through this list
+ * and set every entry's @deleted field to true. The entries will
+ * not be freed automatically. */
+ QLIST_HEAD(, BdrvDeletedStatus) deleted_status;
};
struct BlockBackendRootState {
diff --git a/block.c b/block.c
index 6dd47e414e..0b55c5a41c 100644
--- a/block.c
+++ b/block.c
@@ -3246,10 +3246,16 @@ out:
static void bdrv_delete(BlockDriverState *bs)
{
+ BdrvDeletedStatus *del_stat;
+
assert(!bs->job);
assert(bdrv_op_blocker_is_empty(bs));
assert(!bs->refcnt);
+ QLIST_FOREACH(del_stat, &bs->deleted_status, next) {
+ del_stat->deleted = true;
+ }
+
bdrv_close(bs);
/* remove from list, if necessary */
--
2.13.5
next prev parent reply other threads:[~2017-09-13 18:19 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 18:18 [Qemu-devel] [PATCH 00/18] block/mirror: Add active-sync mirroring Max Reitz
2017-09-13 18:18 ` Max Reitz [this message]
2017-09-13 18:18 ` [Qemu-devel] [PATCH 02/18] block: BDS deletion during bdrv_drain_recurse Max Reitz
2017-09-18 3:44 ` Fam Zheng
2017-09-18 16:13 ` Max Reitz
2017-10-09 18:30 ` Max Reitz
2017-10-10 8:36 ` Kevin Wolf
2017-10-11 11:41 ` Max Reitz
2017-09-13 18:18 ` [Qemu-devel] [PATCH 03/18] blockjob: Make drained_{begin, end} public Max Reitz
2017-09-18 3:46 ` Fam Zheng
2017-09-13 18:18 ` [Qemu-devel] [PATCH 04/18] block/mirror: Pull out mirror_perform() Max Reitz
2017-09-18 3:48 ` Fam Zheng
2017-09-25 9:38 ` Vladimir Sementsov-Ogievskiy
2017-09-13 18:18 ` [Qemu-devel] [PATCH 05/18] block/mirror: Convert to coroutines Max Reitz
2017-09-18 6:02 ` Fam Zheng
2017-09-18 16:41 ` Max Reitz
2017-10-10 9:14 ` Kevin Wolf
2017-10-11 11:43 ` Max Reitz
2017-09-13 18:18 ` [Qemu-devel] [PATCH 06/18] block/mirror: Use CoQueue to wait on in-flight ops Max Reitz
2017-09-13 18:18 ` [Qemu-devel] [PATCH 07/18] block/mirror: Wait for in-flight op conflicts Max Reitz
2017-09-13 18:19 ` [Qemu-devel] [PATCH 08/18] block/mirror: Use source as a BdrvChild Max Reitz
2017-10-10 9:27 ` Kevin Wolf
2017-10-11 11:46 ` Max Reitz
2017-09-13 18:19 ` [Qemu-devel] [PATCH 09/18] block: Generalize should_update_child() rule Max Reitz
2017-09-13 18:19 ` [Qemu-devel] [PATCH 10/18] block/mirror: Make source the file child Max Reitz
2017-10-10 9:47 ` Kevin Wolf
2017-10-11 12:02 ` Max Reitz
2017-09-13 18:19 ` [Qemu-devel] [PATCH 11/18] hbitmap: Add @advance param to hbitmap_iter_next() Max Reitz
2017-09-25 15:38 ` Vladimir Sementsov-Ogievskiy
2017-09-25 20:40 ` Max Reitz
2017-09-13 18:19 ` [Qemu-devel] [PATCH 12/18] block/dirty-bitmap: Add bdrv_dirty_iter_next_area Max Reitz
2017-09-25 15:49 ` Vladimir Sementsov-Ogievskiy
2017-09-25 20:43 ` Max Reitz
2017-10-02 13:32 ` Vladimir Sementsov-Ogievskiy
2017-09-13 18:19 ` [Qemu-devel] [PATCH 13/18] block/mirror: Keep write perm for pending writes Max Reitz
2017-10-10 9:58 ` Kevin Wolf
2017-10-11 12:20 ` Max Reitz
2017-09-13 18:19 ` [Qemu-devel] [PATCH 14/18] block/mirror: Distinguish active from passive ops Max Reitz
2017-09-13 18:19 ` [Qemu-devel] [PATCH 15/18] block/mirror: Add active mirroring Max Reitz
2017-09-14 15:57 ` Stefan Hajnoczi
2017-09-16 13:58 ` Max Reitz
2017-09-18 10:06 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-09-18 16:26 ` Max Reitz
2017-09-19 9:44 ` Stefan Hajnoczi
2017-09-19 9:57 ` Daniel P. Berrange
2017-09-20 14:56 ` Stefan Hajnoczi
2017-10-10 10:16 ` Kevin Wolf
2017-10-11 12:33 ` Max Reitz
2017-09-13 18:19 ` [Qemu-devel] [PATCH 16/18] block/mirror: Add copy mode QAPI interface Max Reitz
2017-09-13 18:19 ` [Qemu-devel] [PATCH 17/18] qemu-io: Add background write Max Reitz
2017-09-18 6:46 ` Fam Zheng
2017-09-18 17:53 ` Max Reitz
2017-09-19 8:03 ` Fam Zheng
2017-09-21 14:40 ` Max Reitz
2017-09-21 14:59 ` Fam Zheng
2017-09-21 15:03 ` Max Reitz
2017-09-13 18:19 ` [Qemu-devel] [PATCH 18/18] iotests: Add test for active mirroring Max Reitz
2017-09-18 6:45 ` Fam Zheng
2017-09-18 16:53 ` Max Reitz
2017-09-19 8:08 ` Fam Zheng
2017-09-14 15:42 ` [Qemu-devel] [PATCH 00/18] block/mirror: Add active-sync mirroring Stefan Hajnoczi
2017-09-16 14:02 ` Max Reitz
2017-09-18 10:02 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2017-09-18 15:42 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170913181910.29688-2-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=famz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).