From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51260) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsMtD-00083s-PJ for qemu-devel@nongnu.org; Thu, 14 Sep 2017 01:40:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsMtC-0005Fj-NP for qemu-devel@nongnu.org; Thu, 14 Sep 2017 01:40:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33862) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dsMtC-0005F2-7Y for qemu-devel@nongnu.org; Thu, 14 Sep 2017 01:40:38 -0400 Date: Thu, 14 Sep 2017 13:40:33 +0800 From: Peter Xu Message-ID: <20170914054033.GJ3617@pxdev.xzpeter.org> References: <20170911132627.9505-1-cohuck@redhat.com> <20170912033333.GA29091@pxdev.xzpeter.org> <20170913095804.4871ffc9.cohuck@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170913095804.4871ffc9.cohuck@redhat.com> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH] dump: do not dump non-existent guest memory List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Cornelia Huck Cc: =?utf-8?Q?Marc-Andr=C3=A9?= Lureau , Laurent Vivier , QEMU , "Dr. David Alan Gilbert" On Wed, Sep 13, 2017 at 09:58:04AM +0200, Cornelia Huck wrote: > On Tue, 12 Sep 2017 12:17:51 +0200 > Marc-Andr=C3=A9 Lureau wrote: >=20 > > Hi Peter > >=20 > > On Tue, Sep 12, 2017 at 5:33 AM, Peter Xu wrote: > > > On Mon, Sep 11, 2017 at 03:26:27PM +0200, Cornelia Huck wrote: =20 > > >> It does not really make sense to dump memory that is not there. > > >> > > >> Moreover, that fixes a segmentation fault when calling dump-guest-= memory > > >> with no filter for a machine with no memory defined. > > >> > > >> New behaviour is: > > >> > > >> (qemu) dump-guest-memory /dev/null > > >> dump: no guest memory to dump > > >> (qemu) dump-guest-memory /dev/null 0 4096 > > >> dump: no guest memory to dump > > >> > > >> Signed-off-by: Cornelia Huck > > >> --- > > >> > > >> Another unmaintained file. Joy. cc:ing some more-or-less random fo= lks. =20 > > > > > > I thought Marc-Andr=C3=A9 had proposed to be the maintainer? But in= deed I > > > didn't see the line in maintainer file. > > > > > > Anyway, if anyone think I am ok to maintain this single file > > > (considering that I haven't posted patches on it for 2 years, and I > > > haven't been working on any kind of maintainer job), please let me > > > know. I'm glad to start with it (or with Marc-Andr=C3=A9). > > > =20 > >=20 > > That would be great! > > thanks >=20 > Now on to the most important question: Will you merge this patch? :) >=20 > (It should probably go together with "tests/hmp: test "none" machine > with memory".) I posted a RFC to maintain this file with Marc-Andr=C3=A9 Lureau, but not getting any acks yet, so I guess at least I don't have that permission, yet... And I see Laruent posted this already: [Qemu-devel] [PATCH v4 0/4] hmp: fix "dump-quest-memory" segfault So I assume all these four patches can go with Dave's tree. Thanks, --=20 Peter Xu