qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Otubo <otubo@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: Thomas Huth <thuth@redhat.com>,
	qemu-devel@nongnu.org, Cornelia Huck <cohuck@redhat.com>,
	David Hildenbrand <david@redhat.com>,
	Claudio Imbrenda <imbrenda@linux.vnet.ibm.com>,
	Dong Jia Shi <bjsdjshi@linux.vnet.ibm.com>,
	Farhan Ali <alifm@linux.vnet.ibm.com>,
	Halil Pasic <pasic@linux.vnet.ibm.com>,
	Jason J Herne <jjherne@linux.vnet.ibm.com>,
	Pierre Morel <pmorel@linux.vnet.ibm.com>,
	Christian Ehrhardt <christian.ehrhardt@canonical.com>
Subject: Re: [Qemu-devel] [PATCH] configure: Allow --enable-seccomp on s390x, too
Date: Thu, 14 Sep 2017 14:05:17 +0200	[thread overview]
Message-ID: <20170914120517.GD24545@vader> (raw)
In-Reply-To: <473d7e2e-2313-3228-259c-b00fd6b1356c@de.ibm.com>

On Thu, Sep 14, 2017 at 01:55:46PM +0200, Christian Borntraeger wrote:
> On 09/14/2017 12:36 PM, Thomas Huth wrote:
> > libseccomp supports s390x since version 2.3.0, and I was able to start
> > a VM with "-sandbox on" without any obvious problems by using this patch,
> > so it should be safe to allow --enable-seccomp on s390x nowadays, too.
> 
> Seems to work fine on s390x.
> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>

Cool, thanks :-)

Acked-by: Eduardo Otubo <otubo@redhat.com>

> 
> > 
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> >  configure | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/configure b/configure
> > index fd7e3a5..83ba64e 100755
> > --- a/configure
> > +++ b/configure
> > @@ -2032,7 +2032,7 @@ if test "$seccomp" != "no" ; then
> >      arm|aarch64)
> >          libseccomp_minver="2.2.3"
> >          ;;
> > -    ppc|ppc64)
> > +    ppc|ppc64|s390x)
> >          libseccomp_minver="2.3.0"
> >          ;;
> >      *)
> > 
> 

-- 
Eduardo Otubo
Senior Software Engineer @ RedHat

  reply	other threads:[~2017-09-14 12:05 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-14 10:36 [Qemu-devel] [PATCH] configure: Allow --enable-seccomp on s390x, too Thomas Huth
2017-09-14 11:24 ` Eduardo Otubo
2017-09-14 11:55 ` Christian Borntraeger
2017-09-14 12:05   ` Eduardo Otubo [this message]
2017-09-14 13:29 ` Halil Pasic
2017-09-14 14:55 ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170914120517.GD24545@vader \
    --to=otubo@redhat.com \
    --cc=alifm@linux.vnet.ibm.com \
    --cc=bjsdjshi@linux.vnet.ibm.com \
    --cc=borntraeger@de.ibm.com \
    --cc=christian.ehrhardt@canonical.com \
    --cc=cohuck@redhat.com \
    --cc=david@redhat.com \
    --cc=imbrenda@linux.vnet.ibm.com \
    --cc=jjherne@linux.vnet.ibm.com \
    --cc=pasic@linux.vnet.ibm.com \
    --cc=pmorel@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).