From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34303) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsTSB-0001lv-TS for qemu-devel@nongnu.org; Thu, 14 Sep 2017 08:41:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsTS7-0000LH-Uy for qemu-devel@nongnu.org; Thu, 14 Sep 2017 08:41:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:55044) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dsTS7-0000Jx-OQ for qemu-devel@nongnu.org; Thu, 14 Sep 2017 08:41:07 -0400 Date: Thu, 14 Sep 2017 13:40:59 +0100 From: "Daniel P. Berrange" Message-ID: <20170914124059.GD15518@redhat.com> Reply-To: "Daniel P. Berrange" References: <20170912123744.14730-1-berrange@redhat.com> <1505223994.31639.20.camel@redhat.com> <20170912141910.GJ17633@redhat.com> <20170912143007.GK17633@redhat.com> <1505390103.31557.11.camel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH v5 00/12] Convert over to use keycodemapdb List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Gerd Hoffmann , QEMU Developers On Thu, Sep 14, 2017 at 12:58:26PM +0100, Peter Maydell wrote: > On 14 September 2017 at 12:55, Gerd Hoffmann wrote: > > Hi, > > > >> I think a better approach is to have something in rules.mak > >> that ensures the submodule is checked out correctly (only > >> when building from GIT, not dist), and then have the rules > >> which generate the keymap files depend on this. > > > > Care sending a patch doing that for dtc? > > It sounds awfully fiddly. Maybe it is the best we can do > given the mess that is git submodules, but is it really > the common approach? I'll do a prototype so we can see something concrete working and evaluate how pleasant (or not) it is Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|