[Qemu-devel] [PATCH 1/1] virtio-ccw: remove stale comments on endiannes

[Qemu-devel] [PATCH 1/1] virtio-ccw: remove stale comments on endiannes

[Halil Pasic]

We have two stale comments suggesting one should think about virtio
config space endiannes a bit longer. We have just done that, and came to
the conclusion we are fine as is: it's the responsibility of the virtio
device and not of the transport (and that is how it works now). Putting
the responsibility into the transport isn't even possible, because the
transport would have to know about the config space layout of each
device.

Let us remove the stale comments.

Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
Suggested-by: Cornelia Huck <cohuck@redhat.com>
---
 hw/s390x/virtio-ccw.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
index b1976fdd19..2262b0cc9a 100644
--- a/hw/s390x/virtio-ccw.c
+++ b/hw/s390x/virtio-ccw.c
@@ -487,7 +487,6 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw)
             ret = -EFAULT;
         } else {
             virtio_bus_get_vdev_config(&dev->bus, vdev->config);
-            /* XXX config space endianness */
             cpu_physical_memory_write(ccw.cda, vdev->config, len);
             sch->curr_status.scsw.count = ccw.count - len;
             ret = 0;
@@ -510,7 +509,6 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw)
                 ret = -EFAULT;
             } else {
                 len = hw_len;
-                /* XXX config space endianness */
                 memcpy(vdev->config, config, len);
                 cpu_physical_memory_unmap(config, hw_len, 0, hw_len);
                 virtio_bus_set_vdev_config(&dev->bus, vdev->config);
-- 
2.13.5

Re: [Qemu-devel] [PATCH 1/1] virtio-ccw: remove stale comments on endiannes

[Cornelia Huck]

On Thu, 14 Sep 2017 12:55:35 +0200
Halil Pasic <pasic@linux.vnet.ibm.com> wrote:

> We have two stale comments suggesting one should think about virtio
> config space endiannes a bit longer. We have just done that, and came to
> the conclusion we are fine as is: it's the responsibility of the virtio
> device and not of the transport (and that is how it works now). Putting
> the responsibility into the transport isn't even possible, because the
> transport would have to know about the config space layout of each
> device.

s/endianes/endianess/

> Let us remove the stale comments.
> 
> Signed-off-by: Halil Pasic <pasic@linux.vnet.ibm.com>
> Suggested-by: Cornelia Huck <cohuck@redhat.com>
> ---
>  hw/s390x/virtio-ccw.c | 2 --
>  1 file changed, 2 deletions(-)

Thanks, applied.