From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, lvivier@redhat.com, cohuck@redhat.com,
vadim.galitsyn@profitbricks.com
Cc: imammedo@redhat.com, thuth@redhat.com, peterx@redhat.com, groug@kaod.org
Subject: [Qemu-devel] [PULL 7/7] hmp: introduce 'info memory_size_summary' command
Date: Thu, 14 Sep 2017 16:04:47 +0100 [thread overview]
Message-ID: <20170914150447.19352-8-dgilbert@redhat.com> (raw)
In-Reply-To: <20170914150447.19352-1-dgilbert@redhat.com>
From: Vadim Galitsyn <vadim.galitsyn@profitbricks.com>
Add 'info memory_size_summary' command which is a sibling
of QMP command query-memory-size-summary. It provides the
following memory information in bytes:
* base-memory - size of "base" memory specified with command line option -m.
* plugged-memory - amount of memory that was hot-plugged.
If target does not have CONFIG_MEM_HOTPLUG enabled, no
value is reported.
Signed-off-by: Vasilis Liaskovitis <vasilis.liaskovitis@profitbricks.com>
Signed-off-by: Mohammed Gamal <mohammed.gamal@profitbricks.com>
Signed-off-by: Eduardo Otubo <eduardo.otubo@profitbricks.com>
Signed-off-by: Vadim Galitsyn <vadim.galitsyn@profitbricks.com>
Reviewed-by: Eugene Crosser <evgenii.cherkashin@profitbricks.com>
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>
Cc: Igor Mammedov <imammedo@redhat.com>
Cc: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org
Message-Id: <20170829153022.27004-4-vadim.galitsyn@profitbricks.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Fixed up comments from Igor's review
---
hmp-commands-info.hx | 16 ++++++++++++++++
hmp.c | 18 ++++++++++++++++++
hmp.h | 1 +
3 files changed, 35 insertions(+)
diff --git a/hmp-commands-info.hx b/hmp-commands-info.hx
index 4ab7fcee98..1c6772597d 100644
--- a/hmp-commands-info.hx
+++ b/hmp-commands-info.hx
@@ -851,6 +851,22 @@ ETEXI
},
STEXI
+@item info memory_size_summary
+@findex memory_size_summary
+Display the amount of initially allocated and present hotpluggable (if
+enabled) memory in bytes.
+ETEXI
+
+ {
+ .name = "memory_size_summary",
+ .args_type = "",
+ .params = "",
+ .help = "show the amount of initially allocated and "
+ "present hotpluggable (if enabled) memory in bytes.",
+ .cmd = hmp_info_memory_size_summary,
+ },
+
+STEXI
@end table
ETEXI
diff --git a/hmp.c b/hmp.c
index cd046c6d71..0fb2bc7043 100644
--- a/hmp.c
+++ b/hmp.c
@@ -2862,3 +2862,21 @@ void hmp_info_vm_generation_id(Monitor *mon, const QDict *qdict)
hmp_handle_error(mon, &err);
qapi_free_GuidInfo(info);
}
+
+void hmp_info_memory_size_summary(Monitor *mon, const QDict *qdict)
+{
+ Error *err = NULL;
+ MemoryInfo *info = qmp_query_memory_size_summary(&err);
+ if (info) {
+ monitor_printf(mon, "base memory: %" PRIu64 "\n",
+ info->base_memory);
+
+ if (info->has_plugged_memory) {
+ monitor_printf(mon, "plugged memory: %" PRIu64 "\n",
+ info->plugged_memory);
+ }
+
+ qapi_free_MemoryInfo(info);
+ }
+ hmp_handle_error(mon, &err);
+}
diff --git a/hmp.h b/hmp.h
index 1ff455295e..3605003e4c 100644
--- a/hmp.h
+++ b/hmp.h
@@ -145,5 +145,6 @@ void hmp_info_dump(Monitor *mon, const QDict *qdict);
void hmp_info_ramblock(Monitor *mon, const QDict *qdict);
void hmp_hotpluggable_cpus(Monitor *mon, const QDict *qdict);
void hmp_info_vm_generation_id(Monitor *mon, const QDict *qdict);
+void hmp_info_memory_size_summary(Monitor *mon, const QDict *qdict);
#endif
--
2.13.5
next prev parent reply other threads:[~2017-09-14 15:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-14 15:04 [Qemu-devel] [PULL 0/7] hmp queue Dr. David Alan Gilbert (git)
2017-09-14 15:04 ` [Qemu-devel] [PULL 1/7] hmp: fix "dump-quest-memory" segfault (ppc) Dr. David Alan Gilbert (git)
2017-09-14 15:04 ` [Qemu-devel] [PULL 2/7] hmp: fix "dump-quest-memory" segfault (arm) Dr. David Alan Gilbert (git)
2017-09-14 15:04 ` [Qemu-devel] [PULL 3/7] dump: do not dump non-existent guest memory Dr. David Alan Gilbert (git)
2017-09-14 15:04 ` [Qemu-devel] [PULL 4/7] tests/hmp: test "none" machine with memory Dr. David Alan Gilbert (git)
2017-09-14 15:04 ` [Qemu-devel] [PULL 5/7] hmp: extend "info numa" with hotplugged memory information Dr. David Alan Gilbert (git)
2017-09-14 15:04 ` [Qemu-devel] [PULL 6/7] qmp: introduce query-memory-size-summary command Dr. David Alan Gilbert (git)
2017-09-14 15:04 ` Dr. David Alan Gilbert (git) [this message]
2017-09-14 16:58 ` [Qemu-devel] [PULL 0/7] hmp queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170914150447.19352-8-dgilbert@redhat.com \
--to=dgilbert@redhat.com \
--cc=cohuck@redhat.com \
--cc=groug@kaod.org \
--cc=imammedo@redhat.com \
--cc=lvivier@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=vadim.galitsyn@profitbricks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).