From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60175) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsWRa-0007p9-Rn for qemu-devel@nongnu.org; Thu, 14 Sep 2017 11:52:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsWRX-0004Vn-3d for qemu-devel@nongnu.org; Thu, 14 Sep 2017 11:52:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37986) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dsWRW-0004VP-TI for qemu-devel@nongnu.org; Thu, 14 Sep 2017 11:52:43 -0400 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id DDC86C047B97 for ; Thu, 14 Sep 2017 15:52:41 +0000 (UTC) Date: Thu, 14 Sep 2017 16:52:35 +0100 From: "Daniel P. Berrange" Message-ID: <20170914155235.GH11763@redhat.com> Reply-To: "Daniel P. Berrange" References: <20170908114407.25906-1-otubo@redhat.com> <20170914153215.GA9252@vader> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20170914153215.GA9252@vader> Subject: Re: [Qemu-devel] [PATCHv6 0/6] seccomp: feature refactoring List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eduardo Otubo Cc: qemu-devel@nongnu.org, thuth@redhat.com On Thu, Sep 14, 2017 at 05:32:15PM +0200, Eduardo Otubo wrote: > On Fri, Sep 08, 2017 at 01:44:02PM +0200, Eduardo Otubo wrote: > > v6: > > * remove switch-case > > * invert obsolete option logic at vl.c > > * remove debug info > > v5: > > * replaced strcmp by g_str_equal > > * removed useless goto > > * fixed style problems > > > > v4: > > * include another field on the struct for the modes > > * remove priority > > * fixed typos > > * error handling for prctl > > * add allow|deny values for all options > > * error hanlding for wrong values for all options > > * change how binary values are treated > > * reformat help text > > > > v3: > > * Style problems fixed > > > > v2: > > * The semantics of the options "allow/deny" instead of booleans "on/off" remains. > > * Added option 'children' to elevateprivileges > > * Added documentation to docs/ > > > > v1: > > * First version based on the discussion > > https://lists.gnu.org/archive/html/qemu-devel/2017-02/msg03348.html > > > > Eduardo Otubo (6): > > seccomp: changing from whitelist to blacklist > > seccomp: add obsolete argument to command line > > seccomp: add elevateprivileges argument to command line > > seccomp: add spawn argument to command line > > seccomp: add resourcecontrol argument to command line > > seccomp: adding documentation to new seccomp model > > > > docs/seccomp.txt | 31 +++++ > > include/sysemu/seccomp.h | 8 +- > > qemu-options.hx | 26 +++- > > qemu-seccomp.c | 325 ++++++++++++++--------------------------------- > > vl.c | 82 +++++++++++- > > 5 files changed, 235 insertions(+), 237 deletions(-) > > create mode 100644 docs/seccomp.txt > > > > -- > > 2.13.5 > > > > > > Daniel or anyone else interested in reviewing, any comment left for > this patchset? If not I'll send the pull request tomorrow. Only one trivial bug in patch 2 - just fix it when sending the pull request - no need for more review. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|