* Re: [Qemu-devel] [PATCH] configure: Allow --enable-seccomp on s390x, too
2017-09-14 10:36 [Qemu-devel] [PATCH] configure: Allow --enable-seccomp on s390x, too Thomas Huth
@ 2017-09-14 11:24 ` Eduardo Otubo
2017-09-14 11:55 ` Christian Borntraeger
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Eduardo Otubo @ 2017-09-14 11:24 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, Cornelia Huck, Christian Borntraeger,
David Hildenbrand, Claudio Imbrenda, Dong Jia Shi, Farhan Ali,
Halil Pasic, Jason J Herne, Pierre Morel, Christian Ehrhardt
On Thu, Sep 14, 2017 at 12:36:03PM +0200, Thomas Huth wrote:
> libseccomp supports s390x since version 2.3.0, and I was able to start
> a VM with "-sandbox on" without any obvious problems by using this patch,
> so it should be safe to allow --enable-seccomp on s390x nowadays, too.
>
I don't have a s390x hardware to test so I'll have to trust you.
Anyone from IBM interested in testing this patch as well?
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index fd7e3a5..83ba64e 100755
> --- a/configure
> +++ b/configure
> @@ -2032,7 +2032,7 @@ if test "$seccomp" != "no" ; then
> arm|aarch64)
> libseccomp_minver="2.2.3"
> ;;
> - ppc|ppc64)
> + ppc|ppc64|s390x)
> libseccomp_minver="2.3.0"
> ;;
> *)
> --
> 1.8.3.1
>
--
Eduardo Otubo
Senior Software Engineer @ RedHat
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH] configure: Allow --enable-seccomp on s390x, too
2017-09-14 10:36 [Qemu-devel] [PATCH] configure: Allow --enable-seccomp on s390x, too Thomas Huth
2017-09-14 11:24 ` Eduardo Otubo
@ 2017-09-14 11:55 ` Christian Borntraeger
2017-09-14 12:05 ` Eduardo Otubo
2017-09-14 13:29 ` Halil Pasic
2017-09-14 14:55 ` Cornelia Huck
3 siblings, 1 reply; 6+ messages in thread
From: Christian Borntraeger @ 2017-09-14 11:55 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Cornelia Huck
Cc: David Hildenbrand, Claudio Imbrenda, Dong Jia Shi, Farhan Ali,
Halil Pasic, Jason J Herne, Pierre Morel, Eduardo Otubo,
Christian Ehrhardt
On 09/14/2017 12:36 PM, Thomas Huth wrote:
> libseccomp supports s390x since version 2.3.0, and I was able to start
> a VM with "-sandbox on" without any obvious problems by using this patch,
> so it should be safe to allow --enable-seccomp on s390x nowadays, too.
Seems to work fine on s390x.
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index fd7e3a5..83ba64e 100755
> --- a/configure
> +++ b/configure
> @@ -2032,7 +2032,7 @@ if test "$seccomp" != "no" ; then
> arm|aarch64)
> libseccomp_minver="2.2.3"
> ;;
> - ppc|ppc64)
> + ppc|ppc64|s390x)
> libseccomp_minver="2.3.0"
> ;;
> *)
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: Allow --enable-seccomp on s390x, too
2017-09-14 11:55 ` Christian Borntraeger
@ 2017-09-14 12:05 ` Eduardo Otubo
0 siblings, 0 replies; 6+ messages in thread
From: Eduardo Otubo @ 2017-09-14 12:05 UTC (permalink / raw)
To: Christian Borntraeger
Cc: Thomas Huth, qemu-devel, Cornelia Huck, David Hildenbrand,
Claudio Imbrenda, Dong Jia Shi, Farhan Ali, Halil Pasic,
Jason J Herne, Pierre Morel, Christian Ehrhardt
On Thu, Sep 14, 2017 at 01:55:46PM +0200, Christian Borntraeger wrote:
> On 09/14/2017 12:36 PM, Thomas Huth wrote:
> > libseccomp supports s390x since version 2.3.0, and I was able to start
> > a VM with "-sandbox on" without any obvious problems by using this patch,
> > so it should be safe to allow --enable-seccomp on s390x nowadays, too.
>
> Seems to work fine on s390x.
> Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Cool, thanks :-)
Acked-by: Eduardo Otubo <otubo@redhat.com>
>
> >
> > Signed-off-by: Thomas Huth <thuth@redhat.com>
> > ---
> > configure | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/configure b/configure
> > index fd7e3a5..83ba64e 100755
> > --- a/configure
> > +++ b/configure
> > @@ -2032,7 +2032,7 @@ if test "$seccomp" != "no" ; then
> > arm|aarch64)
> > libseccomp_minver="2.2.3"
> > ;;
> > - ppc|ppc64)
> > + ppc|ppc64|s390x)
> > libseccomp_minver="2.3.0"
> > ;;
> > *)
> >
>
--
Eduardo Otubo
Senior Software Engineer @ RedHat
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: Allow --enable-seccomp on s390x, too
2017-09-14 10:36 [Qemu-devel] [PATCH] configure: Allow --enable-seccomp on s390x, too Thomas Huth
2017-09-14 11:24 ` Eduardo Otubo
2017-09-14 11:55 ` Christian Borntraeger
@ 2017-09-14 13:29 ` Halil Pasic
2017-09-14 14:55 ` Cornelia Huck
3 siblings, 0 replies; 6+ messages in thread
From: Halil Pasic @ 2017-09-14 13:29 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Cornelia Huck, Christian Borntraeger
Cc: Eduardo Otubo, David Hildenbrand, Farhan Ali, Pierre Morel,
Christian Ehrhardt, Claudio Imbrenda, Jason J Herne, Dong Jia Shi
On 09/14/2017 12:36 PM, Thomas Huth wrote:
> libseccomp supports s390x since version 2.3.0, and I was able to start
> a VM with "-sandbox on" without any obvious problems by using this patch,
> so it should be safe to allow --enable-seccomp on s390x nowadays, too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
ack
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH] configure: Allow --enable-seccomp on s390x, too
2017-09-14 10:36 [Qemu-devel] [PATCH] configure: Allow --enable-seccomp on s390x, too Thomas Huth
` (2 preceding siblings ...)
2017-09-14 13:29 ` Halil Pasic
@ 2017-09-14 14:55 ` Cornelia Huck
3 siblings, 0 replies; 6+ messages in thread
From: Cornelia Huck @ 2017-09-14 14:55 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, Christian Borntraeger, David Hildenbrand,
Claudio Imbrenda, Dong Jia Shi, Farhan Ali, Halil Pasic,
Jason J Herne, Pierre Morel, Eduardo Otubo, Christian Ehrhardt
On Thu, 14 Sep 2017 12:36:03 +0200
Thomas Huth <thuth@redhat.com> wrote:
> libseccomp supports s390x since version 2.3.0, and I was able to start
> a VM with "-sandbox on" without any obvious problems by using this patch,
> so it should be safe to allow --enable-seccomp on s390x nowadays, too.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index fd7e3a5..83ba64e 100755
> --- a/configure
> +++ b/configure
> @@ -2032,7 +2032,7 @@ if test "$seccomp" != "no" ; then
> arm|aarch64)
> libseccomp_minver="2.2.3"
> ;;
> - ppc|ppc64)
> + ppc|ppc64|s390x)
> libseccomp_minver="2.3.0"
> ;;
> *)
Thanks, applied.
^ permalink raw reply [flat|nested] 6+ messages in thread