qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
	Juan Quintela <quintela@redhat.com>,
	qemu-stable@nongnu.org, peterx@redhat.com
Subject: [Qemu-devel] [PATCH 0/3] migration: Fix crash by cleaning up before quit
Date: Fri, 15 Sep 2017 13:44:01 +0800	[thread overview]
Message-ID: <20170915054404.19914-1-famz@redhat.com> (raw)

Quit command causes asssertion failure in block layer due to op blockers added
by BMDS, if there is an active block migration.

Fixing this by calling migration cleaning up functions at the end of main()
before bdrv_close_all() is called.

Fam Zheng (3):
  migration: Allow ram_save_cleanup to be called with empty state
  migration: Cancel migration at exit
  iotests: Add "quit during block migration" case 195

 include/migration/misc.h   |  1 +
 migration/migration.c      |  7 +++-
 migration/ram.c            |  3 ++
 tests/qemu-iotests/195     | 97 ++++++++++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/195.out | 19 +++++++++
 tests/qemu-iotests/group   |  1 +
 vl.c                       |  3 ++
 7 files changed, 130 insertions(+), 1 deletion(-)
 create mode 100755 tests/qemu-iotests/195
 create mode 100644 tests/qemu-iotests/195.out

-- 
2.13.5

             reply	other threads:[~2017-09-15  5:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-15  5:44 Fam Zheng [this message]
2017-09-15  5:44 ` [Qemu-devel] [PATCH 1/3] migration: Allow ram_save_cleanup to be called with empty state Fam Zheng
2017-09-15  6:41   ` Peter Xu
2017-09-15  6:49     ` Fam Zheng
2017-09-15  6:56       ` Peter Xu
2017-09-15  7:02         ` Fam Zheng
2017-09-15  7:58           ` Peter Xu
2017-09-15  5:44 ` [Qemu-devel] [PATCH 2/3] migration: Cancel migration at exit Fam Zheng
2017-09-15  8:03   ` Peter Xu
2017-09-15  8:20     ` Fam Zheng
2017-09-15  8:37       ` Peter Xu
2017-09-15  8:42       ` Dr. David Alan Gilbert
2017-09-15  8:52         ` Fam Zheng
2017-09-15  9:22           ` Dr. David Alan Gilbert
2017-09-18  7:31             ` Peter Xu
2017-09-18 10:00               ` Dr. David Alan Gilbert
2017-09-19  8:26                 ` Peter Xu
2017-09-15  5:44 ` [Qemu-devel] [PATCH 3/3] iotests: Add "quit during block migration" case 195 Fam Zheng
2017-09-15 17:29   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170915054404.19914-1-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=dgilbert@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=quintela@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).