From: James Clarke <jrtc27@jrtc27.com>
To: QEMU Developers <qemu-devel@nongnu.org>
Cc: James Clarke <jrtc27@jrtc27.com>,
John Paul Adrian Glaubitz <glaubitz@physik.fu-berlin.de>,
Laurent Vivier <laurent@vivier.eu>,
Peter Maydell <peter.maydell@linaro.org>
Subject: [Qemu-devel] [PATCH] linux-user/syscall.c: Handle SH4's exceptional alignment for p{read, write}64
Date: Fri, 15 Sep 2017 07:58:21 +0100 [thread overview]
Message-ID: <20170915065821.16600-1-jrtc27@jrtc27.com> (raw)
Fixes: https://bugs.launchpad.net/qemu/+bug/1716767
Signed-off-by: James Clarke <jrtc27@jrtc27.com>
---
linux-user/syscall.c | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 9b6364a266..24d6a81c21 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -10495,20 +10495,32 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
#endif
#ifdef TARGET_NR_pread64
case TARGET_NR_pread64:
+#if defined(TARGET_SH4)
+ /* SH4 doesn't align register pairs, except for p{read,write}64 */
+ arg4 = arg5;
+ arg5 = arg6;
+#else
if (regpairs_aligned(cpu_env)) {
arg4 = arg5;
arg5 = arg6;
}
+#endif
if (!(p = lock_user(VERIFY_WRITE, arg2, arg3, 0)))
goto efault;
ret = get_errno(pread64(arg1, p, arg3, target_offset64(arg4, arg5)));
unlock_user(p, arg2, ret);
break;
case TARGET_NR_pwrite64:
+#if defined(TARGET_SH4)
+ /* SH4 doesn't align register pairs, except for p{read,write}64 */
+ arg4 = arg5;
+ arg5 = arg6;
+#else
if (regpairs_aligned(cpu_env)) {
arg4 = arg5;
arg5 = arg6;
}
+#endif
if (!(p = lock_user(VERIFY_READ, arg2, arg3, 1)))
goto efault;
ret = get_errno(pwrite64(arg1, p, arg3, target_offset64(arg4, arg5)));
--
2.13.2
next reply other threads:[~2017-09-15 6:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-15 6:58 James Clarke [this message]
2017-09-15 7:27 ` [Qemu-devel] [PATCH] linux-user/syscall.c: Handle SH4's exceptional alignment for p{read, write}64 Laurent Vivier
2017-09-15 15:07 ` John Paul Adrian Glaubitz
2017-09-15 15:41 ` Philippe Mathieu-Daudé
2017-09-15 15:43 ` John Paul Adrian Glaubitz
2017-09-15 17:13 ` Richard Henderson
2017-09-15 18:39 ` Laurent Vivier
2017-09-15 19:07 ` [Qemu-devel] [PATCH v2] " James Clarke
2017-09-15 19:24 ` no-reply
2017-09-15 19:33 ` [Qemu-devel] [PATCH v3] " James Clarke
2017-09-15 19:51 ` Eric Blake
2017-09-15 20:11 ` Laurent Vivier
2017-09-15 20:12 ` Richard Henderson
2017-09-15 20:41 ` John Paul Adrian Glaubitz
2017-09-15 20:45 ` John Paul Adrian Glaubitz
2017-09-15 21:10 ` Philippe Mathieu-Daudé
2017-10-04 8:38 ` John Paul Adrian Glaubitz
2017-11-04 7:30 ` [Qemu-devel] PING: " John Paul Adrian Glaubitz
2017-11-06 19:57 ` [Qemu-devel] " Riku Voipio
2017-11-06 20:00 ` James Clarke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170915065821.16600-1-jrtc27@jrtc27.com \
--to=jrtc27@jrtc27.com \
--cc=glaubitz@physik.fu-berlin.de \
--cc=laurent@vivier.eu \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).