From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44292) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dsqZv-0000df-Ot for qemu-devel@nongnu.org; Fri, 15 Sep 2017 09:22:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dsqZs-0007XW-Gi for qemu-devel@nongnu.org; Fri, 15 Sep 2017 09:22:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:16694) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dsqZs-0007XJ-9w for qemu-devel@nongnu.org; Fri, 15 Sep 2017 09:22:40 -0400 Date: Fri, 15 Sep 2017 15:22:29 +0200 From: Cornelia Huck Message-ID: <20170915152229.3a955efa.cohuck@redhat.com> In-Reply-To: References: <20170915101406.27823-1-cohuck@redhat.com> <20170915101406.27823-2-cohuck@redhat.com> <37791e7b-c096-3e88-4121-4f1739615367@redhat.com> <20170915150705.359a5356.cohuck@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH RFC 1/1] s390x/ccw: create s390 phb for compat reasons as well List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand Cc: qemu-devel@nongnu.org, borntraeger@de.ibm.com, agraf@suse.de, thuth@redhat.com, pmorel@linux.vnet.ibm.com, zyimin@linux.vnet.ibm.com, pasic@linux.vnet.ibm.com On Fri, 15 Sep 2017 15:09:02 +0200 David Hildenbrand wrote: > On 15.09.2017 15:07, Cornelia Huck wrote: > > On Fri, 15 Sep 2017 13:57:40 +0200 > > David Hildenbrand wrote: > > > >> As an alternative, simply > >> > >> diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c > >> index 0f28ebd162..0f22efc3b6 100644 > >> --- a/target/s390x/cpu_models.c > >> +++ b/target/s390x/cpu_models.c > >> @@ -195,6 +195,8 @@ bool s390_has_feat(S390Feat feat) > >> return true; > >> } > >> } > >> + if (feat == S390_FEAT_ZPCI) > >> + return true; > > > > Move that out of the CONFIG_KVM #ifdef? > > > > Should not make a difference I think, cpu models are not shielded off > for TCG I think (maybe we should fix that, but doesn't look that easy - > they have no host model which would allow cpu->model = NULL). It just looks odd to have it inside the define... > > > (Also, we still have the issue with pci support :/ - depend on > > pci_available?) > > hm .... Should we maybe disallow compat machines if CONFIG_PCI is off, and think about something for the 2.11 machine? Otherwise, I cannot see that end well :/ But I'll just draw up a v2 for now.