From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42443) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dt18D-00007d-E5 for qemu-devel@nongnu.org; Fri, 15 Sep 2017 20:38:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dt18A-0007XE-Bt for qemu-devel@nongnu.org; Fri, 15 Sep 2017 20:38:49 -0400 Received: from mx1.redhat.com ([209.132.183.28]:59398) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dt18A-0007Wf-54 for qemu-devel@nongnu.org; Fri, 15 Sep 2017 20:38:46 -0400 Date: Fri, 15 Sep 2017 21:38:32 -0300 From: Eduardo Habkost Message-ID: <20170916003832.GF10621@localhost.localdomain> References: <20170915230744.22942-1-ehabkost@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Qemu-devel] [PATCH] MAINTAINERS: Add Python scripts List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: John Snow Cc: qemu-devel@nongnu.org, Kevin Wolf , =?utf-8?B?THVrw6HFoQ==?= Doktor , Fam Zheng , Markus Armbruster , Amador Pahim , Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= , Max Reitz , Stefan Hajnoczi , Cleber Rosa , Paolo Bonzini On Fri, Sep 15, 2017 at 08:17:18PM -0400, John Snow wrote: > > > On 09/15/2017 07:07 PM, Eduardo Habkost wrote: > > Cleber and I are volunteering to review and queue patches for the > > Python scripts and modules in scripts/. > > > > I'm setting "M: Odd fixes" because not all scripts are actively > > maintained. > > > > Signed-off-by: Eduardo Habkost > > --- > > Even before this patch is merged, I plan to send a pull request > > including some patches for the Python code soon. > > --- > > MAINTAINERS | 7 +++++++ > > 1 file changed, 7 insertions(+) > > > > diff --git a/MAINTAINERS b/MAINTAINERS > > index 2c333aba21..2c3b8ecde7 100644 > > --- a/MAINTAINERS > > +++ b/MAINTAINERS > > @@ -1390,6 +1390,13 @@ S: Maintained > > F: include/sysemu/cryptodev*.h > > F: backends/cryptodev*.c > > > > +Python scripts > > +M: Eduardo Habkost > > +M: Cleber Rosa > > +S: Odd fixes > > +F: scripts/qmp/* > > +F: scripts/*.py > > + > > QAPI > > M: Markus Armbruster > > M: Michael Roth > > > > I rather like the thought of having dedicated Python maintainers who can > review python code with an eye for what is idiomatic. I am fairly > certain the python I write is functional, but I'm rarely sure it's what > a python programmer would do. > > I suppose you are intentionally omitting any python that exists as part > of the test infrastructure, however? Initially, yes. I was trying to include only the stuff we were actively maintaining. But later I decided to use "S: Odd fixes" instead of "S: Maintained", so I guess it won't hurt to include this: --- diff --git a/MAINTAINERS b/MAINTAINERS index 2c3b8ecde7..876ac0df99 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1396,6 +1396,8 @@ M: Cleber Rosa S: Odd fixes F: scripts/qmp/* F: scripts/*.py +F: tests/*.py +K: #!.*python QAPI M: Markus Armbruster -- Eduardo