* [Qemu-devel] [PATCH] MAINTAINERS: Add Python scripts
@ 2017-09-15 23:07 Eduardo Habkost
2017-09-16 0:17 ` John Snow
0 siblings, 1 reply; 4+ messages in thread
From: Eduardo Habkost @ 2017-09-15 23:07 UTC (permalink / raw)
To: qemu-devel
Cc: Amador Pahim, Paolo Bonzini, Philippe Mathieu-Daudé,
Fam Zheng, Kevin Wolf, Max Reitz, Lukáš Doktor,
John Snow, Cleber Rosa, Markus Armbruster, Stefan Hajnoczi
Cleber and I are volunteering to review and queue patches for the
Python scripts and modules in scripts/.
I'm setting "M: Odd fixes" because not all scripts are actively
maintained.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
Even before this patch is merged, I plan to send a pull request
including some patches for the Python code soon.
---
MAINTAINERS | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 2c333aba21..2c3b8ecde7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1390,6 +1390,13 @@ S: Maintained
F: include/sysemu/cryptodev*.h
F: backends/cryptodev*.c
+Python scripts
+M: Eduardo Habkost <ehabkost@redhat.com>
+M: Cleber Rosa <crosa@redhat.com>
+S: Odd fixes
+F: scripts/qmp/*
+F: scripts/*.py
+
QAPI
M: Markus Armbruster <armbru@redhat.com>
M: Michael Roth <mdroth@linux.vnet.ibm.com>
--
2.13.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: Add Python scripts
2017-09-15 23:07 [Qemu-devel] [PATCH] MAINTAINERS: Add Python scripts Eduardo Habkost
@ 2017-09-16 0:17 ` John Snow
2017-09-16 0:38 ` Eduardo Habkost
0 siblings, 1 reply; 4+ messages in thread
From: John Snow @ 2017-09-16 0:17 UTC (permalink / raw)
To: Eduardo Habkost, qemu-devel
Cc: Kevin Wolf, Lukáš Doktor, Fam Zheng, Markus Armbruster,
Amador Pahim, Philippe Mathieu-Daudé, Max Reitz,
Stefan Hajnoczi, Cleber Rosa, Paolo Bonzini
On 09/15/2017 07:07 PM, Eduardo Habkost wrote:
> Cleber and I are volunteering to review and queue patches for the
> Python scripts and modules in scripts/.
>
> I'm setting "M: Odd fixes" because not all scripts are actively
> maintained.
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> ---
> Even before this patch is merged, I plan to send a pull request
> including some patches for the Python code soon.
> ---
> MAINTAINERS | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 2c333aba21..2c3b8ecde7 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1390,6 +1390,13 @@ S: Maintained
> F: include/sysemu/cryptodev*.h
> F: backends/cryptodev*.c
>
> +Python scripts
> +M: Eduardo Habkost <ehabkost@redhat.com>
> +M: Cleber Rosa <crosa@redhat.com>
> +S: Odd fixes
> +F: scripts/qmp/*
> +F: scripts/*.py
> +
> QAPI
> M: Markus Armbruster <armbru@redhat.com>
> M: Michael Roth <mdroth@linux.vnet.ibm.com>
>
I rather like the thought of having dedicated Python maintainers who can
review python code with an eye for what is idiomatic. I am fairly
certain the python I write is functional, but I'm rarely sure it's what
a python programmer would do.
I suppose you are intentionally omitting any python that exists as part
of the test infrastructure, however?
John
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: Add Python scripts
2017-09-16 0:17 ` John Snow
@ 2017-09-16 0:38 ` Eduardo Habkost
2017-09-18 9:40 ` Stefan Hajnoczi
0 siblings, 1 reply; 4+ messages in thread
From: Eduardo Habkost @ 2017-09-16 0:38 UTC (permalink / raw)
To: John Snow
Cc: qemu-devel, Kevin Wolf, Lukáš Doktor, Fam Zheng,
Markus Armbruster, Amador Pahim, Philippe Mathieu-Daudé,
Max Reitz, Stefan Hajnoczi, Cleber Rosa, Paolo Bonzini
On Fri, Sep 15, 2017 at 08:17:18PM -0400, John Snow wrote:
>
>
> On 09/15/2017 07:07 PM, Eduardo Habkost wrote:
> > Cleber and I are volunteering to review and queue patches for the
> > Python scripts and modules in scripts/.
> >
> > I'm setting "M: Odd fixes" because not all scripts are actively
> > maintained.
> >
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> > Even before this patch is merged, I plan to send a pull request
> > including some patches for the Python code soon.
> > ---
> > MAINTAINERS | 7 +++++++
> > 1 file changed, 7 insertions(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 2c333aba21..2c3b8ecde7 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1390,6 +1390,13 @@ S: Maintained
> > F: include/sysemu/cryptodev*.h
> > F: backends/cryptodev*.c
> >
> > +Python scripts
> > +M: Eduardo Habkost <ehabkost@redhat.com>
> > +M: Cleber Rosa <crosa@redhat.com>
> > +S: Odd fixes
> > +F: scripts/qmp/*
> > +F: scripts/*.py
> > +
> > QAPI
> > M: Markus Armbruster <armbru@redhat.com>
> > M: Michael Roth <mdroth@linux.vnet.ibm.com>
> >
>
> I rather like the thought of having dedicated Python maintainers who can
> review python code with an eye for what is idiomatic. I am fairly
> certain the python I write is functional, but I'm rarely sure it's what
> a python programmer would do.
>
> I suppose you are intentionally omitting any python that exists as part
> of the test infrastructure, however?
Initially, yes. I was trying to include only the stuff we were
actively maintaining. But later I decided to use "S: Odd fixes"
instead of "S: Maintained", so I guess it won't hurt to include
this:
---
diff --git a/MAINTAINERS b/MAINTAINERS
index 2c3b8ecde7..876ac0df99 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -1396,6 +1396,8 @@ M: Cleber Rosa <crosa@redhat.com>
S: Odd fixes
F: scripts/qmp/*
F: scripts/*.py
+F: tests/*.py
+K: #!.*python
QAPI
M: Markus Armbruster <armbru@redhat.com>
--
Eduardo
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] MAINTAINERS: Add Python scripts
2017-09-16 0:38 ` Eduardo Habkost
@ 2017-09-18 9:40 ` Stefan Hajnoczi
0 siblings, 0 replies; 4+ messages in thread
From: Stefan Hajnoczi @ 2017-09-18 9:40 UTC (permalink / raw)
To: Eduardo Habkost
Cc: John Snow, Kevin Wolf, Lukáš Doktor, Fam Zheng,
Amador Pahim, qemu-devel, Markus Armbruster, Stefan Hajnoczi,
Cleber Rosa, Paolo Bonzini, Max Reitz,
Philippe Mathieu-Daudé
On Fri, Sep 15, 2017 at 09:38:32PM -0300, Eduardo Habkost wrote:
> On Fri, Sep 15, 2017 at 08:17:18PM -0400, John Snow wrote:
> >
> >
> > On 09/15/2017 07:07 PM, Eduardo Habkost wrote:
> > > Cleber and I are volunteering to review and queue patches for the
> > > Python scripts and modules in scripts/.
> > >
> > > I'm setting "M: Odd fixes" because not all scripts are actively
> > > maintained.
> > >
> > > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > > ---
> > > Even before this patch is merged, I plan to send a pull request
> > > including some patches for the Python code soon.
> > > ---
> > > MAINTAINERS | 7 +++++++
> > > 1 file changed, 7 insertions(+)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 2c333aba21..2c3b8ecde7 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -1390,6 +1390,13 @@ S: Maintained
> > > F: include/sysemu/cryptodev*.h
> > > F: backends/cryptodev*.c
> > >
> > > +Python scripts
> > > +M: Eduardo Habkost <ehabkost@redhat.com>
> > > +M: Cleber Rosa <crosa@redhat.com>
> > > +S: Odd fixes
> > > +F: scripts/qmp/*
> > > +F: scripts/*.py
> > > +
> > > QAPI
> > > M: Markus Armbruster <armbru@redhat.com>
> > > M: Michael Roth <mdroth@linux.vnet.ibm.com>
> > >
> >
> > I rather like the thought of having dedicated Python maintainers who can
> > review python code with an eye for what is idiomatic. I am fairly
> > certain the python I write is functional, but I'm rarely sure it's what
> > a python programmer would do.
> >
> > I suppose you are intentionally omitting any python that exists as part
> > of the test infrastructure, however?
>
> Initially, yes. I was trying to include only the stuff we were
> actively maintaining. But later I decided to use "S: Odd fixes"
> instead of "S: Maintained", so I guess it won't hurt to include
> this:
>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-18 9:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-15 23:07 [Qemu-devel] [PATCH] MAINTAINERS: Add Python scripts Eduardo Habkost
2017-09-16 0:17 ` John Snow
2017-09-16 0:38 ` Eduardo Habkost
2017-09-18 9:40 ` Stefan Hajnoczi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).