From: Kevin Wolf <kwolf@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block: Clean up some bad code in the vvfat driver
Date: Tue, 19 Sep 2017 10:02:21 +0200 [thread overview]
Message-ID: <20170919080221.GC3789@localhost.localdomain> (raw)
In-Reply-To: <1505298088-10878-1-git-send-email-thuth@redhat.com>
Am 13.09.2017 um 12:21 hat Thomas Huth geschrieben:
> Remove the unnecessary home-grown redefinition of the assert() macro here,
> and remove the unusable debug code at the end of the checkpoint() function.
> The code there uses assert() with side-effects (assignment to the "mapping"
> variable), which should be avoided. Looking more closely, it seems as it is
> apparently also only usable for one certain directory layout (with a file
> named USB.H in it) and thus is of no use for the rest of the world.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2017-09-19 8:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-13 10:21 [Qemu-devel] [PATCH] block: Clean up some bad code in the vvfat driver Thomas Huth
2017-09-13 13:57 ` Eric Blake
2017-09-13 19:08 ` [Qemu-devel] [Qemu-block] " John Snow
2017-09-19 8:06 ` Paolo Bonzini
2017-09-19 8:14 ` [Qemu-devel] Dead code in cpu-models.h (was: block: Clean up some bad code in the vvfat driver) Thomas Huth
2017-09-19 18:54 ` [Qemu-devel] Dead code in cpu-models.h John Snow
2017-09-19 19:05 ` Thomas Huth
2017-09-19 19:01 ` [Qemu-devel] [Qemu-block] [PATCH] block: Clean up some bad code in the vvfat driver John Snow
2017-09-19 19:08 ` Thomas Huth
2017-09-19 8:02 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170919080221.GC3789@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).