From: Stefan Hajnoczi <stefanha@gmail.com>
To: Eric Blake <eblake@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-trivial@nongnu.org,
Paolo Bonzini <pbonzini@redhat.com>,
"open list:Network Block Dev..." <qemu-block@nongnu.org>,
Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH] nbd-client: Use correct macro parenthesization
Date: Tue, 19 Sep 2017 10:13:04 +0100 [thread overview]
Message-ID: <20170919091304.GA22797@stefanha-x1.localdomain> (raw)
In-Reply-To: <20170918214649.17550-1-eblake@redhat.com>
On Mon, Sep 18, 2017 at 04:46:49PM -0500, Eric Blake wrote:
> If 'bs' is a complex expression, we were only casting the front half
> rather than the full expression. Luckily, none of the callers were
> passing bad arguments, but it's better to be robust up front.
>
> Signed-off-by: Eric Blake <eblake@redhat.com>
> ---
>
> I plan to take this through my NBD queue, unless it is picked up
> by qemu-trivial first...
>
> block/nbd-client.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
next prev parent reply other threads:[~2017-09-19 9:13 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 21:46 [Qemu-devel] [PATCH] nbd-client: Use correct macro parenthesization Eric Blake
2017-09-18 22:13 ` [Qemu-devel] [Qemu-trivial] " Philippe Mathieu-Daudé
2017-09-18 22:42 ` Eric Blake
2017-09-19 10:32 ` Philippe Mathieu-Daudé
2017-09-19 14:16 ` Eric Blake
2017-09-19 9:13 ` Stefan Hajnoczi [this message]
2017-09-24 20:59 ` [Qemu-devel] " Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170919091304.GA22797@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).