* [Qemu-devel] [PATCH] nvme: fix cmbuf leak on exit
@ 2017-09-19 9:48 Stefan Hajnoczi
2017-09-19 11:00 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Hajnoczi @ 2017-09-19 9:48 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-block, Kevin Wolf, Stefan Hajnoczi, Keith Busch
Cc: Keith Busch <keith.busch@intel.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---
hw/block/nvme.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 9aa32692a3..513ec7065d 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -1057,6 +1057,7 @@ static void nvme_exit(PCIDevice *pci_dev)
g_free(n->namespaces);
g_free(n->cq);
g_free(n->sq);
+ g_free(n->cmbuf);
if (n->cmbsz) {
memory_region_unref(&n->ctrl_mem);
}
--
2.13.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] nvme: fix cmbuf leak on exit
2017-09-19 9:48 [Qemu-devel] [PATCH] nvme: fix cmbuf leak on exit Stefan Hajnoczi
@ 2017-09-19 11:00 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2017-09-19 11:00 UTC (permalink / raw)
To: Stefan Hajnoczi; +Cc: qemu-devel, Kevin Wolf, Keith Busch, qemu-block
Hi Stefan,
On 09/19/2017 06:48 AM, Stefan Hajnoczi wrote:
> Cc: Keith Busch <keith.busch@intel.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
> ---
> hw/block/nvme.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/block/nvme.c b/hw/block/nvme.c
> index 9aa32692a3..513ec7065d 100644
> --- a/hw/block/nvme.c
> +++ b/hw/block/nvme.c
> @@ -1057,6 +1057,7 @@ static void nvme_exit(PCIDevice *pci_dev)
> g_free(n->namespaces);
> g_free(n->cq);
> g_free(n->sq);
> + g_free(n->cmbuf);
I'd move it 1 line below,
> if (n->cmbsz) {
here:
g_free(n->cmbuf);
> memory_region_unref(&n->ctrl_mem);
> }
>
Anyway g_free() handles NULL, so:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-19 11:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-19 9:48 [Qemu-devel] [PATCH] nvme: fix cmbuf leak on exit Stefan Hajnoczi
2017-09-19 11:00 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).