From: Eduardo Habkost <ehabkost@redhat.com>
To: Mohammed Gamal <mgamal@redhat.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com, thuth@redhat.com,
peterx@redhat.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [PATCH v4 2/3] intel_iommu, amd_iommu: Remove redundant object_dynamic_cast calls
Date: Tue, 19 Sep 2017 11:22:38 -0300 [thread overview]
Message-ID: <20170919142238.GF3030@localhost.localdomain> (raw)
In-Reply-To: <1505745470-12208-3-git-send-email-mgamal@redhat.com>
On Mon, Sep 18, 2017 at 04:37:49PM +0200, Mohammed Gamal wrote:
> Now that the calling x86_iommu_realize() calls object_dynamic_cast(),
> doing the cast in amdvi_realize() and vtd_realize() is not needed.
>
> Use PC_MACHINE macro directly.
>
> Signed-off-by: Mohammed Gamal <mgamal@redhat.com>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
I suggest squashing this into patch 1/3. It doesn't need to be a
separate patch.
--
Eduardo
next prev parent reply other threads:[~2017-09-19 14:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-18 14:37 [Qemu-devel] [PATCH v4 0/3] x86_iommu: Fix segfault when starting on non-PCI machines Mohammed Gamal
2017-09-18 14:37 ` [Qemu-devel] [PATCH v4 1/3] x86_iommu: Move machine check to x86_iommu_realize() Mohammed Gamal
2017-09-19 14:21 ` Eduardo Habkost
2017-09-18 14:37 ` [Qemu-devel] [PATCH v4 2/3] intel_iommu, amd_iommu: Remove redundant object_dynamic_cast calls Mohammed Gamal
2017-09-19 14:22 ` Eduardo Habkost [this message]
2017-09-18 14:37 ` [Qemu-devel] [PATCH v4 3/3] x86_iommu: check if machine has PCI bus Mohammed Gamal
2017-09-19 14:22 ` Eduardo Habkost
2017-09-20 2:39 ` [Qemu-devel] [PATCH v4 0/3] x86_iommu: Fix segfault when starting on non-PCI machines Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170919142238.GF3030@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=mgamal@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).