qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Cornelia Huck <cohuck@redhat.com>
To: peter.maydell@linaro.org
Cc: qemu-devel@nongnu.org, rth@twiddle.net, agraf@suse.de,
	thuth@redhat.com, borntraeger@de.ibm.com, david@redhat.com,
	Cornelia Huck <cohuck@redhat.com>
Subject: [Qemu-devel] [PULL 18/38] s390x: move sclp_service_call() to sclp.h
Date: Tue, 19 Sep 2017 16:56:16 +0200	[thread overview]
Message-ID: <20170919145636.9389-19-cohuck@redhat.com> (raw)
In-Reply-To: <20170919145636.9389-1-cohuck@redhat.com>

From: David Hildenbrand <david@redhat.com>

Implemented in sclp.c, so let's move it to the right include file.
Also adjust some includes.

Signed-off-by: David Hildenbrand <david@redhat.com>
Message-Id: <20170913132417.24384-9-david@redhat.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
 include/hw/s390x/sclp.h    | 2 ++
 target/s390x/cpu.h         | 1 -
 target/s390x/misc_helper.c | 1 +
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/include/hw/s390x/sclp.h b/include/hw/s390x/sclp.h
index a72d096081..847ff32f85 100644
--- a/include/hw/s390x/sclp.h
+++ b/include/hw/s390x/sclp.h
@@ -16,6 +16,7 @@
 
 #include "hw/sysbus.h"
 #include "hw/qdev.h"
+#include "target/s390x/cpu-qom.h"
 
 #define SCLP_CMD_CODE_MASK                      0xffff00ff
 
@@ -242,5 +243,6 @@ sclpMemoryHotplugDev *init_sclp_memory_hotplug_dev(void);
 sclpMemoryHotplugDev *get_sclp_memory_hotplug_dev(void);
 void sclp_service_interrupt(uint32_t sccb);
 void raise_irq_cpu_hotplug(void);
+int sclp_service_call(CPUS390XState *env, uint64_t sccb, uint32_t code);
 
 #endif
diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h
index 4a0a59dfbc..5295bd3c66 100644
--- a/target/s390x/cpu.h
+++ b/target/s390x/cpu.h
@@ -722,6 +722,5 @@ int s390_cpu_virt_mem_rw(S390CPU *cpu, vaddr laddr, uint8_t ar, void *hostbuf,
 
 /* outside of target/s390x/ */
 S390CPU *s390_cpu_addr2state(uint16_t cpu_addr);
-int sclp_service_call(CPUS390XState *env, uint64_t sccb, uint32_t code);
 
 #endif
diff --git a/target/s390x/misc_helper.c b/target/s390x/misc_helper.c
index b142db71c6..8b07535b02 100644
--- a/target/s390x/misc_helper.c
+++ b/target/s390x/misc_helper.c
@@ -35,6 +35,7 @@
 #include "sysemu/sysemu.h"
 #include "hw/s390x/ebcdic.h"
 #include "hw/s390x/s390-virtio-hcall.h"
+#include "hw/s390x/sclp.h"
 #endif
 
 /* #define DEBUG_HELPER */
-- 
2.13.5

  parent reply	other threads:[~2017-09-19 14:58 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-19 14:55 [Qemu-devel] [PULL 00/38] various s390x patches (+some fixes) Cornelia Huck
2017-09-19 14:55 ` [Qemu-devel] [PULL 01/38] s390x/css: fix cc handling for XSCH Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 02/38] tests: Enable the drive_del test also on s390x Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 03/38] s390x/pci: remove idx from msix msg data Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 04/38] s390x/pci: fixup ind_offset of msix routing entry Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 05/38] s390x/pci: add iommu replay callback Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 06/38] hw/misc/ivshmem: Fix ivshmem_recv_msg() to also work on big endian systems Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 07/38] s390x/css: drop data-check in interpretation Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 08/38] s390x/css: fix NULL handling for CCW addresses Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 09/38] s390x/css: remove unused error handling branch Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 10/38] s390: set DHCP client architecure id for netboot Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 11/38] exec, dump, i386, ppc, s390x: don't include exec/cpu-all.h explicitly Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 12/38] cpu: drop old comments describing members Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 13/38] s390x: get rid of s390-virtio.c Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 14/38] s390x: rename s390-virtio.h to s390-virtio-hcall.h Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 15/38] s390x: move s390_virtio_hypercall() " Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 16/38] s390x: move subsystem_reset() to s390-virtio-ccw.h Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 17/38] target/s390x: move some s390x typedefs to cpu-qom.h Cornelia Huck
2017-09-19 14:56 ` Cornelia Huck [this message]
2017-09-19 14:56 ` [Qemu-devel] [PULL 19/38] target/s390x: use trigger_pgm_exception() in s390_cpu_handle_mmu_fault() Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 20/38] target/s390x: use program_interrupt() in per_check_exception() Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 21/38] s390x: allow only 1 CPU with TCG Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 22/38] target/s390x: set cpu->id for linux user when realizing Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 23/38] target/s390x: use "core-id" for cpu number/address/id handling Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 24/38] target/s390x: rename next_cpu_id to next_core_id Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 25/38] s390x: print CPU definitions in sorted order Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 26/38] s390x: allow cpu hotplug via device_add Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 27/38] s390x: CPU hot unplug via device_del cannot work for now Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 28/38] s390x: implement query-hotpluggable-cpus Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 29/38] s390x: get rid of cpu_states and use possible_cpus instead Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 30/38] s390x: get rid of cpu_s390x_create() Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 31/38] s390x: generate sclp cpu information from possible_cpus Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 32/38] s390x: allow CPU hotplug in random core-id order Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 33/38] virtio-ccw: remove stale comments on endianness Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 34/38] configure: Allow --enable-seccomp on s390x, too Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 35/38] s390x/ccw: create s390 phb for compat reasons as well Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 36/38] virtio-gpu: Handle endian conversion Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 37/38] virtio-ccw: Create a virtio gpu device for the ccw bus Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 38/38] MAINTAINERS/s390x: add terminal3270.c Cornelia Huck
2017-09-19 16:13 ` [Qemu-devel] [PULL 00/38] various s390x patches (+some fixes) Peter Maydell
2017-09-19 16:27   ` Cornelia Huck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170919145636.9389-19-cohuck@redhat.com \
    --to=cohuck@redhat.com \
    --cc=agraf@suse.de \
    --cc=borntraeger@de.ibm.com \
    --cc=david@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).