From: Cornelia Huck <cohuck@redhat.com>
To: peter.maydell@linaro.org
Cc: qemu-devel@nongnu.org, rth@twiddle.net, agraf@suse.de,
thuth@redhat.com, borntraeger@de.ibm.com, david@redhat.com,
Farhan Ali <alifm@linux.vnet.ibm.com>,
Cornelia Huck <cohuck@redhat.com>
Subject: [Qemu-devel] [PULL 37/38] virtio-ccw: Create a virtio gpu device for the ccw bus
Date: Tue, 19 Sep 2017 16:56:35 +0200 [thread overview]
Message-ID: <20170919145636.9389-38-cohuck@redhat.com> (raw)
In-Reply-To: <20170919145636.9389-1-cohuck@redhat.com>
From: Farhan Ali <alifm@linux.vnet.ibm.com>
Wire up the virtio-gpu device for the CCW bus. The virtio-gpu
is a virtio-1 device, so disable revision 0.
Signed-off-by: Farhan Ali <alifm@linux.vnet.ibm.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
Reviewed-by: Halil Pasic <pasic@linux.vnet.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Message-Id: <6c53f939cf2d64b66d2a6878b29c9bf3820f3d5b.1505485574.git.alifm@linux.vnet.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
---
hw/s390x/virtio-ccw.c | 49 +++++++++++++++++++++++++++++++++++++++++++++++++
hw/s390x/virtio-ccw.h | 10 ++++++++++
2 files changed, 59 insertions(+)
diff --git a/hw/s390x/virtio-ccw.c b/hw/s390x/virtio-ccw.c
index 2262b0cc9a..ff1bb1534c 100644
--- a/hw/s390x/virtio-ccw.c
+++ b/hw/s390x/virtio-ccw.c
@@ -1005,6 +1005,15 @@ static void virtio_ccw_crypto_realize(VirtioCcwDevice *ccw_dev, Error **errp)
NULL);
}
+static void virtio_ccw_gpu_realize(VirtioCcwDevice *ccw_dev, Error **errp)
+{
+ VirtIOGPUCcw *dev = VIRTIO_GPU_CCW(ccw_dev);
+ DeviceState *vdev = DEVICE(&dev->vdev);
+
+ qdev_set_parent_bus(vdev, BUS(&ccw_dev->bus));
+ object_property_set_bool(OBJECT(vdev), true, "realized", errp);
+}
+
/* DeviceState to VirtioCcwDevice. Note: used on datapath,
* be careful and test performance if you change this.
*/
@@ -1614,6 +1623,45 @@ static const TypeInfo virtio_ccw_crypto = {
.class_init = virtio_ccw_crypto_class_init,
};
+static Property virtio_ccw_gpu_properties[] = {
+ DEFINE_PROP_BIT("ioeventfd", VirtioCcwDevice, flags,
+ VIRTIO_CCW_FLAG_USE_IOEVENTFD_BIT, true),
+ DEFINE_PROP_UINT32("max_revision", VirtioCcwDevice, max_rev,
+ VIRTIO_CCW_MAX_REV),
+ DEFINE_PROP_END_OF_LIST(),
+};
+
+static void virtio_ccw_gpu_instance_init(Object *obj)
+{
+ VirtIOGPUCcw *dev = VIRTIO_GPU_CCW(obj);
+ VirtioCcwDevice *ccw_dev = VIRTIO_CCW_DEVICE(obj);
+
+ ccw_dev->force_revision_1 = true;
+ virtio_instance_init_common(obj, &dev->vdev, sizeof(dev->vdev),
+ TYPE_VIRTIO_GPU);
+}
+
+static void virtio_ccw_gpu_class_init(ObjectClass *klass, void *data)
+{
+ DeviceClass *dc = DEVICE_CLASS(klass);
+ VirtIOCCWDeviceClass *k = VIRTIO_CCW_DEVICE_CLASS(klass);
+
+ k->realize = virtio_ccw_gpu_realize;
+ k->exit = virtio_ccw_exit;
+ dc->reset = virtio_ccw_reset;
+ dc->props = virtio_ccw_gpu_properties;
+ dc->hotpluggable = false;
+ set_bit(DEVICE_CATEGORY_DISPLAY, dc->categories);
+}
+
+static const TypeInfo virtio_ccw_gpu = {
+ .name = TYPE_VIRTIO_GPU_CCW,
+ .parent = TYPE_VIRTIO_CCW_DEVICE,
+ .instance_size = sizeof(VirtIOGPUCcw),
+ .instance_init = virtio_ccw_gpu_instance_init,
+ .class_init = virtio_ccw_gpu_class_init,
+};
+
static void virtio_ccw_busdev_realize(DeviceState *dev, Error **errp)
{
VirtioCcwDevice *_dev = (VirtioCcwDevice *)dev;
@@ -1813,6 +1861,7 @@ static void virtio_ccw_register(void)
type_register_static(&vhost_vsock_ccw_info);
#endif
type_register_static(&virtio_ccw_crypto);
+ type_register_static(&virtio_ccw_gpu);
}
type_init(virtio_ccw_register)
diff --git a/hw/s390x/virtio-ccw.h b/hw/s390x/virtio-ccw.h
index 41d4010378..541fdd2994 100644
--- a/hw/s390x/virtio-ccw.h
+++ b/hw/s390x/virtio-ccw.h
@@ -27,6 +27,7 @@
#ifdef CONFIG_VHOST_VSOCK
#include "hw/virtio/vhost-vsock.h"
#endif /* CONFIG_VHOST_VSOCK */
+#include "hw/virtio/virtio-gpu.h"
#include "hw/s390x/s390_flic.h"
#include "hw/s390x/css.h"
@@ -223,4 +224,13 @@ typedef struct VHostVSockCCWState {
#endif /* CONFIG_VHOST_VSOCK */
+#define TYPE_VIRTIO_GPU_CCW "virtio-gpu-ccw"
+#define VIRTIO_GPU_CCW(obj) \
+ OBJECT_CHECK(VirtIOGPUCcw, (obj), TYPE_VIRTIO_GPU_CCW)
+
+typedef struct VirtIOGPUCcw {
+ VirtioCcwDevice parent_obj;
+ VirtIOGPU vdev;
+} VirtIOGPUCcw;
+
#endif
--
2.13.5
next prev parent reply other threads:[~2017-09-19 15:01 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 14:55 [Qemu-devel] [PULL 00/38] various s390x patches (+some fixes) Cornelia Huck
2017-09-19 14:55 ` [Qemu-devel] [PULL 01/38] s390x/css: fix cc handling for XSCH Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 02/38] tests: Enable the drive_del test also on s390x Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 03/38] s390x/pci: remove idx from msix msg data Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 04/38] s390x/pci: fixup ind_offset of msix routing entry Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 05/38] s390x/pci: add iommu replay callback Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 06/38] hw/misc/ivshmem: Fix ivshmem_recv_msg() to also work on big endian systems Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 07/38] s390x/css: drop data-check in interpretation Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 08/38] s390x/css: fix NULL handling for CCW addresses Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 09/38] s390x/css: remove unused error handling branch Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 10/38] s390: set DHCP client architecure id for netboot Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 11/38] exec, dump, i386, ppc, s390x: don't include exec/cpu-all.h explicitly Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 12/38] cpu: drop old comments describing members Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 13/38] s390x: get rid of s390-virtio.c Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 14/38] s390x: rename s390-virtio.h to s390-virtio-hcall.h Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 15/38] s390x: move s390_virtio_hypercall() " Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 16/38] s390x: move subsystem_reset() to s390-virtio-ccw.h Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 17/38] target/s390x: move some s390x typedefs to cpu-qom.h Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 18/38] s390x: move sclp_service_call() to sclp.h Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 19/38] target/s390x: use trigger_pgm_exception() in s390_cpu_handle_mmu_fault() Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 20/38] target/s390x: use program_interrupt() in per_check_exception() Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 21/38] s390x: allow only 1 CPU with TCG Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 22/38] target/s390x: set cpu->id for linux user when realizing Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 23/38] target/s390x: use "core-id" for cpu number/address/id handling Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 24/38] target/s390x: rename next_cpu_id to next_core_id Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 25/38] s390x: print CPU definitions in sorted order Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 26/38] s390x: allow cpu hotplug via device_add Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 27/38] s390x: CPU hot unplug via device_del cannot work for now Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 28/38] s390x: implement query-hotpluggable-cpus Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 29/38] s390x: get rid of cpu_states and use possible_cpus instead Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 30/38] s390x: get rid of cpu_s390x_create() Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 31/38] s390x: generate sclp cpu information from possible_cpus Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 32/38] s390x: allow CPU hotplug in random core-id order Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 33/38] virtio-ccw: remove stale comments on endianness Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 34/38] configure: Allow --enable-seccomp on s390x, too Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 35/38] s390x/ccw: create s390 phb for compat reasons as well Cornelia Huck
2017-09-19 14:56 ` [Qemu-devel] [PULL 36/38] virtio-gpu: Handle endian conversion Cornelia Huck
2017-09-19 14:56 ` Cornelia Huck [this message]
2017-09-19 14:56 ` [Qemu-devel] [PULL 38/38] MAINTAINERS/s390x: add terminal3270.c Cornelia Huck
2017-09-19 16:13 ` [Qemu-devel] [PULL 00/38] various s390x patches (+some fixes) Peter Maydell
2017-09-19 16:27 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170919145636.9389-38-cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=agraf@suse.de \
--cc=alifm@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=david@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).