From: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
To: qemu-devel@nongnu.org, quintela@redhat.com, peterx@redhat.com
Cc: peter.maydell@linaro.org, cohuck@redhat.com, rth@twiddle.net
Subject: [Qemu-devel] [PATCH 0/5] migration: let pre_save fail
Date: Tue, 19 Sep 2017 19:00:33 +0100 [thread overview]
Message-ID: <20170919180038.26056-1-dgilbert@redhat.com> (raw)
From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
At the moment the pre-save method on VMStateDescription returns void
which means there's no sane way of a pre_save routine failing. There
are quite a few pre_save's that abort or do other nasty things, and it
would be better if they could fail cleanly.
This patch series doesn't fix any of those pre_save's - it just changes
pre_save to return an error value and routes that back up so the
migration fails. I'll leave that up to the individual device owners.
There are a bunch of corner cases that I've not fixed yet; these are
mostly places that call vmstate_save_state which have been partially
converted to modern migration code; often the functions they're called
from return void as well - they can get fixed later.
Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Dr. David Alan Gilbert (5):
migration: pre_save return int
migration: check pre_save return in vmstate_save_state
migration: wire vmstate_save_state errors up to
vmstate_subsection_save
migration: Route errors up through vmstate_save
migration: Route more error paths
docs/devel/migration.txt | 2 +-
hw/arm/pxa2xx.c | 4 +++-
hw/arm/strongarm.c | 4 +++-
hw/audio/wm8750.c | 4 +++-
hw/block/fdc.c | 4 +++-
hw/block/m25p80.c | 4 +++-
hw/block/nand.c | 4 +++-
hw/block/onenand.c | 4 +++-
hw/char/serial.c | 4 +++-
hw/display/qxl.c | 4 +++-
hw/display/virtio-gpu.c | 4 +---
hw/i2c/core.c | 4 +++-
hw/i386/kvm/clock.c | 4 +++-
hw/ide/core.c | 4 +++-
hw/ide/pci.c | 4 +++-
hw/input/ps2.c | 8 ++++++--
hw/input/tsc210x.c | 4 +++-
hw/intc/apic_common.c | 4 +++-
hw/intc/arm_gic_common.c | 4 +++-
hw/intc/arm_gicv3_common.c | 4 +++-
hw/intc/arm_gicv3_its_common.c | 4 +++-
hw/intc/i8259_common.c | 4 +++-
hw/intc/ioapic_common.c | 4 +++-
hw/intc/s390_flic_kvm.c | 6 ++++--
hw/intc/xics.c | 8 ++++++--
hw/net/e1000.c | 4 +++-
hw/net/e1000e.c | 4 +++-
hw/net/rtl8139.c | 4 +++-
hw/net/virtio-net.c | 16 ++++++++++++----
hw/net/vmxnet3.c | 4 +++-
hw/pci-host/piix.c | 4 +++-
hw/ppc/ppc.c | 4 +++-
hw/ppc/spapr_iommu.c | 4 +++-
hw/ppc/spapr_pci.c | 6 ++++--
hw/s390x/css.c | 10 +++++++---
hw/s390x/virtio-ccw.c | 4 +++-
hw/scsi/lsi53c895a.c | 4 +++-
hw/scsi/vmw_pvscsi.c | 4 +++-
hw/timer/cadence_ttc.c | 4 +++-
hw/timer/hpet.c | 4 +++-
hw/timer/i8254_common.c | 4 +++-
hw/timer/mc146818rtc.c | 4 +++-
hw/timer/pl031.c | 4 +++-
hw/timer/twl92230.c | 4 +++-
hw/usb/dev-smartcard-reader.c | 4 +++-
hw/usb/hcd-ehci.c | 4 +++-
hw/usb/redirect.c | 4 +++-
hw/virtio/vhost-vsock.c | 4 +++-
hw/virtio/virtio.c | 13 +++++++------
include/hw/virtio/virtio.h | 2 +-
include/migration/vmstate.h | 6 +++---
migration/colo-comm.c | 4 +++-
migration/global_state.c | 4 +++-
migration/savevm.c | 23 +++++++++++++++++------
migration/trace-events | 1 +
migration/vmstate-types.c | 11 ++++++++---
migration/vmstate.c | 34 +++++++++++++++++++++++++---------
replay/replay-snapshot.c | 4 +++-
slirp/slirp.c | 8 ++++++--
target/arm/machine.c | 4 +++-
target/i386/machine.c | 7 +++++--
target/ppc/machine.c | 4 +++-
target/s390x/machine.c | 4 +++-
target/sparc/machine.c | 4 +++-
tests/test-vmstate.c | 10 ++++++----
65 files changed, 261 insertions(+), 102 deletions(-)
--
2.13.5
next reply other threads:[~2017-09-19 18:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 18:00 Dr. David Alan Gilbert (git) [this message]
2017-09-19 18:00 ` [Qemu-devel] [PATCH 1/5] migration: pre_save return int Dr. David Alan Gilbert (git)
2017-09-20 13:57 ` Cornelia Huck
2017-09-20 14:32 ` Dr. David Alan Gilbert
2017-09-19 18:00 ` [Qemu-devel] [PATCH 2/5] migration: check pre_save return in vmstate_save_state Dr. David Alan Gilbert (git)
2017-09-19 18:00 ` [Qemu-devel] [PATCH 3/5] migration: wire vmstate_save_state errors up to vmstate_subsection_save Dr. David Alan Gilbert (git)
2017-09-19 18:00 ` [Qemu-devel] [PATCH 4/5] migration: Route errors up through vmstate_save Dr. David Alan Gilbert (git)
2017-09-19 18:00 ` [Qemu-devel] [PATCH 5/5] migration: Route more error paths Dr. David Alan Gilbert (git)
2017-09-20 3:31 ` Peter Xu
2017-09-20 15:45 ` Dr. David Alan Gilbert
2017-09-20 3:55 ` Fam Zheng
2017-09-20 13:26 ` Eric Blake
2017-09-20 14:20 ` Dr. David Alan Gilbert
2017-09-20 15:32 ` Eric Blake
2017-09-20 14:30 ` Cornelia Huck
2017-09-20 15:57 ` Dr. David Alan Gilbert
2017-09-20 16:00 ` Cornelia Huck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170919180038.26056-1-dgilbert@redhat.com \
--to=dgilbert@redhat.com \
--cc=cohuck@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).