qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: qemu-stable@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: [Qemu-devel] [PATCH 09/12] mps2-an511: Fix wiring of UART overflow interrupt lines
Date: Tue, 19 Sep 2017 19:45:18 -0500	[thread overview]
Message-ID: <20170920004521.9417-10-mdroth@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170920004521.9417-1-mdroth@linux.vnet.ibm.com>

From: Peter Maydell <peter.maydell@linaro.org>

Fix an error that meant we were wiring every UART's overflow
interrupts into the same inputs 0 and 1 of the OR gate,
rather than giving each its own input.

Cc: qemu-stable@nongnu.org
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Alistair Francis <alistair.francis@xilinx.com>
Message-id: 1505232834-20890-1-git-send-email-peter.maydell@linaro.org
(cherry picked from commit ce3bc112cdb1d462e2d52eaa17a7314e7f3af504)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
 hw/arm/mps2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/arm/mps2.c b/hw/arm/mps2.c
index abb0ab6d71..769cff872c 100644
--- a/hw/arm/mps2.c
+++ b/hw/arm/mps2.c
@@ -287,8 +287,8 @@ static void mps2_common_init(MachineState *machine)
             cmsdk_apb_uart_create(uartbase[i],
                                   qdev_get_gpio_in(txrx_orgate_dev, 0),
                                   qdev_get_gpio_in(txrx_orgate_dev, 1),
-                                  qdev_get_gpio_in(orgate_dev, 0),
-                                  qdev_get_gpio_in(orgate_dev, 1),
+                                  qdev_get_gpio_in(orgate_dev, i * 2),
+                                  qdev_get_gpio_in(orgate_dev, i * 2 + 1),
                                   NULL,
                                   uartchr, SYSCLK_FRQ);
         }
-- 
2.11.0

  parent reply	other threads:[~2017-09-20  0:46 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-20  0:45 [Qemu-devel] [PATCH 00/12] Patch Round-up for stable 2.10.1, freeze on 2017-09-27 Michael Roth
2017-09-20  0:45 ` [Qemu-devel] [PATCH 01/12] slirp: fix clearing ifq_so from pending packets Michael Roth
2017-09-20  0:45 ` [Qemu-devel] [PATCH 02/12] s390-ccw: Fix alignment for CCW1 Michael Roth
2017-09-20  0:45 ` [Qemu-devel] [PATCH 03/12] target/arm: Fix aa64 ldp register writeback Michael Roth
2017-09-20  0:45 ` [Qemu-devel] [PATCH 04/12] virtfs: error out gracefully when mandatory suboptions are missing Michael Roth
2017-09-20  0:45 ` [Qemu-devel] [PATCH 05/12] arm_gicv3_kvm: Fix compile warning Michael Roth
2017-09-20  0:45 ` [Qemu-devel] [PATCH 06/12] hw/arm/allwinner-a10: Mark the allwinner-a10 device with user_creatable = false Michael Roth
2017-09-20  0:45 ` [Qemu-devel] [PATCH 07/12] qcow2: move qcow2_store_persistent_dirty_bitmaps() before cache flushing Michael Roth
2017-09-20  0:45 ` [Qemu-devel] [PATCH 08/12] vhost: Release memory references on cleanup Michael Roth
2017-09-20  0:45 ` Michael Roth [this message]
2017-09-20  0:45 ` [Qemu-devel] [PATCH 10/12] scsi-bus: correct responses for INQUIRY and REQUEST SENSE Michael Roth
2017-09-20  0:45 ` [Qemu-devel] [PATCH 11/12] libvhost-user: support resuming vq->last_avail_idx based on used_idx Michael Roth
2017-09-20  0:45 ` [Qemu-devel] [PATCH 12/12] vhost-user-bridge: fix resume regression (since 2.9) Michael Roth
2017-09-20  7:16 ` [Qemu-devel] [PATCH 00/12] Patch Round-up for stable 2.10.1, freeze on 2017-09-27 Thomas Huth
2017-09-20 22:25 ` Greg Kurz
2017-09-25 20:55 ` Michael Roth
2017-09-28 22:37   ` [Qemu-devel] [Qemu-stable] " Bruce Rogers
2017-09-26 14:37 ` [Qemu-devel] " Anthony PERARD
2017-09-26 18:13 ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170920004521.9417-10-mdroth@linux.vnet.ibm.com \
    --to=mdroth@linux.vnet.ibm.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).