From: David Gibson <david@gibson.dropbear.id.au>
To: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Cc: qemu-ppc@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCHv2] macio: convert pmac_ide_ops from old_mmio
Date: Wed, 20 Sep 2017 16:32:34 +1000 [thread overview]
Message-ID: <20170920063234.GL5520@umbus.fritz.box> (raw)
In-Reply-To: <b8b0190f-0dd0-dc60-d5cb-fcf356a954d8@ilande.co.uk>
[-- Attachment #1: Type: text/plain, Size: 1785 bytes --]
On Wed, Sep 20, 2017 at 07:28:27AM +0100, Mark Cave-Ayland wrote:
> On 20/09/17 07:00, David Gibson wrote:
>
> > On Wed, Sep 20, 2017 at 06:56:37AM +0100, Mark Cave-Ayland wrote:
> >> On 20/09/17 05:29, David Gibson wrote:
> >>
> >>> On Tue, Sep 19, 2017 at 09:02:54PM +0100, Mark Cave-Ayland wrote:
> >>>> Signed-off-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
> >>>
> >>> This didn't apply for me. Can you rebase on top of ppc-for-2.11, please.
> >>
> >> (goes and looks)
> >>
> >> Okay looks like the issue is that you're missing "[PATCH 3/8]
> >> ppc/ide/macio: Add missing registers" from your queue - I see you
> >> replied with an applied to ppc-2.11 email so I bet this got dropped on
> >> rebase somewhere.
> >
> > Oh, sorry. Not sure how that happened.
> >
> >> Can you try again with that patch added and then let me know if it still
> >> doesn't work?
> >
> > Uh.. I've lost track of it, I'm afraid. Can you resend it and the
> > ide_ops one as a series.
>
> Done. BTW if possible can you keep them in a similar order, i.e. ensure
> that "ppc/ide/macio: Add missing registers" comes before "ppc: Fix
> OpenPIC model"? (See
> https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg04397.html for
> the full set).
Done.
> This is because in my testing Linux will see the change in OpenPIC model
> and try to access the new macio registers, and so if that patch isn't
> there first then you end up with a hang on boot. Keeping the order will
> help make things much easier for bisection.
>
>
> ATB,
>
> Mark.
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-09-20 6:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-19 20:02 [Qemu-devel] [PATCHv2] macio: convert pmac_ide_ops from old_mmio Mark Cave-Ayland
2017-09-20 4:29 ` David Gibson
2017-09-20 5:56 ` Mark Cave-Ayland
2017-09-20 6:00 ` David Gibson
2017-09-20 6:28 ` Mark Cave-Ayland
2017-09-20 6:32 ` David Gibson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170920063234.GL5520@umbus.fritz.box \
--to=david@gibson.dropbear.id.au \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).