* [Qemu-devel] [PATCH] usb: Use angle brackets for cacard include directive
@ 2017-09-20 8:59 Fam Zheng
2017-09-29 10:34 ` Fam Zheng
0 siblings, 1 reply; 4+ messages in thread
From: Fam Zheng @ 2017-09-20 8:59 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
This is a library header, so angle brackets are more appropriate; also
move the line to before QEMU headers, as is recommended in HACKING.
Signed-off-by: Fam Zheng <famz@redhat.com>
---
hw/usb/ccid-card-passthru.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/ccid-card-passthru.c b/hw/usb/ccid-card-passthru.c
index 45d96b03c6..117711862e 100644
--- a/hw/usb/ccid-card-passthru.c
+++ b/hw/usb/ccid-card-passthru.c
@@ -9,11 +9,11 @@
*/
#include "qemu/osdep.h"
+#include <cacard/vscard_common.h>
#include "chardev/char-fe.h"
#include "qemu/error-report.h"
#include "qemu/sockets.h"
#include "ccid.h"
-#include "cacard/vscard_common.h"
#define DPRINTF(card, lvl, fmt, ...) \
do { \
--
2.13.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] usb: Use angle brackets for cacard include directive
2017-09-20 8:59 [Qemu-devel] [PATCH] usb: Use angle brackets for cacard include directive Fam Zheng
@ 2017-09-29 10:34 ` Fam Zheng
2017-09-29 10:42 ` Gerd Hoffmann
0 siblings, 1 reply; 4+ messages in thread
From: Fam Zheng @ 2017-09-29 10:34 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann, qemu-trivial
On Wed, 09/20 16:59, Fam Zheng wrote:
> This is a library header, so angle brackets are more appropriate; also
> move the line to before QEMU headers, as is recommended in HACKING.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> hw/usb/ccid-card-passthru.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/usb/ccid-card-passthru.c b/hw/usb/ccid-card-passthru.c
> index 45d96b03c6..117711862e 100644
> --- a/hw/usb/ccid-card-passthru.c
> +++ b/hw/usb/ccid-card-passthru.c
> @@ -9,11 +9,11 @@
> */
>
> #include "qemu/osdep.h"
> +#include <cacard/vscard_common.h>
> #include "chardev/char-fe.h"
> #include "qemu/error-report.h"
> #include "qemu/sockets.h"
> #include "ccid.h"
> -#include "cacard/vscard_common.h"
>
> #define DPRINTF(card, lvl, fmt, ...) \
> do { \
> --
> 2.13.5
>
>
Cc: qemu-trivial@nongnu.org
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-09-29 10:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-20 8:59 [Qemu-devel] [PATCH] usb: Use angle brackets for cacard include directive Fam Zheng
2017-09-29 10:34 ` Fam Zheng
2017-09-29 10:42 ` Gerd Hoffmann
2017-09-29 10:59 ` Fam Zheng
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).