[Qemu-devel] [PATCH] tests: Move postcopy migration test to migrate-set-parameters

[Qemu-devel] [PATCH] tests: Move postcopy migration test to migrate-set-parameters

[Juan Quintela]

migrate_set_speed and migrate_set_dowtime are deprecated since long ago.

Signed-off-by: Juan Quintela <quintela@redhat.com>
---
 tests/postcopy-test.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/tests/postcopy-test.c b/tests/postcopy-test.c
index 8142f2ab90..991b954a83 100644
--- a/tests/postcopy-test.c
+++ b/tests/postcopy-test.c
@@ -430,14 +430,14 @@ static void test_migrate(void)
      * machine, so also set the downtime.
      */
     global_qtest = from;
-    rsp = qmp("{ 'execute': 'migrate_set_speed',"
-              "'arguments': { 'value': 100000000 } }");
+    rsp = qmp("{ 'execute': 'migrate-set-parameters',"
+              "'arguments': { 'max-bandwidth': 100000000 } }");
     g_assert(qdict_haskey(rsp, "return"));
     QDECREF(rsp);
 
     /* 1ms downtime - it should never finish precopy */
-    rsp = qmp("{ 'execute': 'migrate_set_downtime',"
-              "'arguments': { 'value': 0.001 } }");
+    rsp = qmp("{ 'execute': 'migrate-set-parameters',"
+              "'arguments': { 'downtime-limit': 1 } }");
     g_assert(qdict_haskey(rsp, "return"));
     QDECREF(rsp);
 
-- 
2.13.5

Re: [Qemu-devel] [PATCH] tests: Move postcopy migration test to migrate-set-parameters

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 559 bytes --]

On 09/20/2017 05:50 AM, Juan Quintela wrote:
> migrate_set_speed and migrate_set_dowtime are deprecated since long ago.

s/dowtime/downtime/

Still, even if they are deprecated, maintaining coverage for both old
and new spellings in the testsuite doesn't hurt, does it?  Maybe it
would be better to add a comment stating that our use of the old
interface is intentional, or to run the test twice, once per spelling?


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]