qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: qemu-devel@nongnu.org
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH qemu v4 10/18] memory: Alloc dispatch tree where topology is generared
Date: Wed, 20 Sep 2017 21:46:29 +1000	[thread overview]
Message-ID: <20170920114637.42004-11-aik@ozlabs.ru> (raw)
In-Reply-To: <20170920114637.42004-1-aik@ozlabs.ru>

This is to make next patches simpler.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
 memory.c | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)

diff --git a/memory.c b/memory.c
index 98b0b95e6e..eb730cd619 100644
--- a/memory.c
+++ b/memory.c
@@ -742,6 +742,7 @@ static MemoryRegion *memory_region_get_flatview_root(MemoryRegion *mr)
 /* Render a memory topology into a list of disjoint absolute ranges. */
 static FlatView *generate_memory_topology(MemoryRegion *mr)
 {
+    int i;
     FlatView *view;
 
     view = flatview_new(mr);
@@ -752,6 +753,14 @@ static FlatView *generate_memory_topology(MemoryRegion *mr)
     }
     flatview_simplify(view);
 
+    view->dispatch = address_space_dispatch_new(view);
+    for (i = 0; i < view->nr; i++) {
+        MemoryRegionSection mrs =
+            section_from_flat_range(&view->ranges[i], view);
+        flatview_add_to_dispatch(view, &mrs);
+    }
+    address_space_dispatch_compact(view->dispatch);
+
     return view;
 }
 
@@ -921,15 +930,6 @@ static void address_space_update_topology(AddressSpace *as)
     FlatView *old_view = address_space_get_flatview(as);
     MemoryRegion *physmr = memory_region_get_flatview_root(old_view->root);
     FlatView *new_view = generate_memory_topology(physmr);
-    int i;
-
-    new_view->dispatch = address_space_dispatch_new(new_view);
-    for (i = 0; i < new_view->nr; i++) {
-        MemoryRegionSection mrs =
-            section_from_flat_range(&new_view->ranges[i], new_view);
-        flatview_add_to_dispatch(new_view, &mrs);
-    }
-    address_space_dispatch_compact(new_view->dispatch);
 
     if (!QTAILQ_EMPTY(&as->listeners)) {
         address_space_update_topology_pass(as, old_view, new_view, false);
-- 
2.11.0

  parent reply	other threads:[~2017-09-20 14:15 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-20 11:46 [Qemu-devel] [PATCH qemu v4 00/18] memory: Reduce memory use Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 01/18] exec: Explicitly export target AS from address_space_translate_internal Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 02/18] memory: Open code FlatView rendering Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 03/18] memory: Move FlatView allocation to a helper Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 04/18] memory: Move AddressSpaceDispatch from AddressSpace to FlatView Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 05/18] memory: Remove AddressSpace pointer from AddressSpaceDispatch Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 06/18] memory: Switch memory from using AddressSpace to FlatView Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 07/18] memory: Cleanup after switching " Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 08/18] memory: Rename mem_begin/mem_commit/mem_add helpers Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 09/18] memory: Store physical root MR in FlatView Alexey Kardashevskiy
2017-09-20 17:15   ` Paolo Bonzini
2017-09-21  0:02     ` Alexey Kardashevskiy
2017-09-21  5:22       ` Alexey Kardashevskiy
2017-09-21  6:28         ` Alexey Kardashevskiy
2017-09-20 11:46 ` Alexey Kardashevskiy [this message]
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 11/18] memory: Move address_space_update_ioeventfds Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 12/18] memory: Share FlatView's and dispatch trees between address spaces Alexey Kardashevskiy
2017-09-20 17:18   ` Paolo Bonzini
2017-09-20 23:53     ` Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 13/18] memory: Do not allocate FlatView in address_space_init Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 14/18] memory: Add flat views to HMP "info mtree" Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 15/18] memory: Share special empty FlatView Alexey Kardashevskiy
2017-09-20 17:13   ` Paolo Bonzini
2017-09-20 23:48     ` Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 16/18] memory: Get rid of address_space_init_shareable Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 17/18] memory: Create FlatView directly Alexey Kardashevskiy
2017-09-20 17:18   ` Paolo Bonzini
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 18/18] memory: Give memory_region_transaction_commit a hint Alexey Kardashevskiy
2017-09-20 17:14   ` Paolo Bonzini
2017-09-21  0:02     ` Alexey Kardashevskiy
2017-09-21  7:34       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170920114637.42004-11-aik@ozlabs.ru \
    --to=aik@ozlabs.ru \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).