qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alexey Kardashevskiy <aik@ozlabs.ru>
To: qemu-devel@nongnu.org
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
	Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH qemu v4 01/18] exec: Explicitly export target AS from address_space_translate_internal
Date: Wed, 20 Sep 2017 21:46:20 +1000	[thread overview]
Message-ID: <20170920114637.42004-2-aik@ozlabs.ru> (raw)
In-Reply-To: <20170920114637.42004-1-aik@ozlabs.ru>

This adds an AS** parameter to address_space_do_translate()
to make it easier for the next patch to share FlatViews.

This should cause no behavioural change.

Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
 exec.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/exec.c b/exec.c
index a25a4c6018..fd8994b25d 100644
--- a/exec.c
+++ b/exec.c
@@ -476,7 +476,8 @@ static MemoryRegionSection address_space_do_translate(AddressSpace *as,
                                                       hwaddr *xlat,
                                                       hwaddr *plen,
                                                       bool is_write,
-                                                      bool is_mmio)
+                                                      bool is_mmio,
+                                                      AddressSpace **target_as)
 {
     IOMMUTLBEntry iotlb;
     MemoryRegionSection *section;
@@ -503,6 +504,7 @@ static MemoryRegionSection address_space_do_translate(AddressSpace *as,
         }
 
         as = iotlb.target_as;
+        *target_as = iotlb.target_as;
     }
 
     *xlat = addr;
@@ -525,7 +527,7 @@ IOMMUTLBEntry address_space_get_iotlb_entry(AddressSpace *as, hwaddr addr,
 
     /* This can never be MMIO. */
     section = address_space_do_translate(as, addr, &xlat, &plen,
-                                         is_write, false);
+                                         is_write, false, &as);
 
     /* Illegal translation */
     if (section.mr == &io_mem_unassigned) {
@@ -548,7 +550,7 @@ IOMMUTLBEntry address_space_get_iotlb_entry(AddressSpace *as, hwaddr addr,
     plen -= 1;
 
     return (IOMMUTLBEntry) {
-        .target_as = section.address_space,
+        .target_as = as,
         .iova = addr & ~plen,
         .translated_addr = xlat & ~plen,
         .addr_mask = plen,
@@ -569,7 +571,8 @@ MemoryRegion *address_space_translate(AddressSpace *as, hwaddr addr,
     MemoryRegionSection section;
 
     /* This can be MMIO, so setup MMIO bit. */
-    section = address_space_do_translate(as, addr, xlat, plen, is_write, true);
+    section = address_space_do_translate(as, addr, xlat, plen, is_write, true,
+                                         &as);
     mr = section.mr;
 
     if (xen_enabled() && memory_access_is_direct(mr, is_write)) {
-- 
2.11.0

  reply	other threads:[~2017-09-20 14:15 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-20 11:46 [Qemu-devel] [PATCH qemu v4 00/18] memory: Reduce memory use Alexey Kardashevskiy
2017-09-20 11:46 ` Alexey Kardashevskiy [this message]
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 02/18] memory: Open code FlatView rendering Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 03/18] memory: Move FlatView allocation to a helper Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 04/18] memory: Move AddressSpaceDispatch from AddressSpace to FlatView Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 05/18] memory: Remove AddressSpace pointer from AddressSpaceDispatch Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 06/18] memory: Switch memory from using AddressSpace to FlatView Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 07/18] memory: Cleanup after switching " Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 08/18] memory: Rename mem_begin/mem_commit/mem_add helpers Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 09/18] memory: Store physical root MR in FlatView Alexey Kardashevskiy
2017-09-20 17:15   ` Paolo Bonzini
2017-09-21  0:02     ` Alexey Kardashevskiy
2017-09-21  5:22       ` Alexey Kardashevskiy
2017-09-21  6:28         ` Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 10/18] memory: Alloc dispatch tree where topology is generared Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 11/18] memory: Move address_space_update_ioeventfds Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 12/18] memory: Share FlatView's and dispatch trees between address spaces Alexey Kardashevskiy
2017-09-20 17:18   ` Paolo Bonzini
2017-09-20 23:53     ` Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 13/18] memory: Do not allocate FlatView in address_space_init Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 14/18] memory: Add flat views to HMP "info mtree" Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 15/18] memory: Share special empty FlatView Alexey Kardashevskiy
2017-09-20 17:13   ` Paolo Bonzini
2017-09-20 23:48     ` Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 16/18] memory: Get rid of address_space_init_shareable Alexey Kardashevskiy
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 17/18] memory: Create FlatView directly Alexey Kardashevskiy
2017-09-20 17:18   ` Paolo Bonzini
2017-09-20 11:46 ` [Qemu-devel] [PATCH qemu v4 18/18] memory: Give memory_region_transaction_commit a hint Alexey Kardashevskiy
2017-09-20 17:14   ` Paolo Bonzini
2017-09-21  0:02     ` Alexey Kardashevskiy
2017-09-21  7:34       ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170920114637.42004-2-aik@ozlabs.ru \
    --to=aik@ozlabs.ru \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).