From: Kevin Wolf <kwolf@redhat.com>
To: Manos Pitsidianakis <el13635@mail.ntua.gr>
Cc: qemu-devel <qemu-devel@nongnu.org>,
qemu-block <qemu-block@nongnu.org>, Max Reitz <mreitz@redhat.com>,
John Snow <jsnow@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 2/2] block/block-backend.c: remove blk_pread_unthrottled()
Date: Wed, 20 Sep 2017 14:37:40 +0200 [thread overview]
Message-ID: <20170920123740.GE4730@localhost.localdomain> (raw)
In-Reply-To: <20170920114310.13080-3-el13635@mail.ntua.gr>
Am 20.09.2017 um 13:43 hat Manos Pitsidianakis geschrieben:
> blk_pread_unthrottled was used to bypass I/O throttling on the BlockBackend in
> the case of async I/O. This is not needed anymore and we can just call
> blk_pread() directly.
>
> Signed-off-by: Manos Pitsidianakis <el13635@mail.ntua.gr>
We already did a related commit to the same effect in block/io.c:
commit 90c78624f157ba41c3761c1a54864de03a7ec350
Author: Kevin Wolf <kwolf@redhat.com>
Date: Thu Apr 7 18:33:29 2016 +0200
block: Don't disable I/O throttling on sync requests
We had to disable I/O throttling with synchronous requests because we
didn't use to run timers in nested event loops when the code was
introduced. This isn't true any more, and throttling works just fine
even when using the synchronous API.
The removed code is in fact dead code since commit a8823a3b ('block: Use
blk_co_pwritev() for blk_write()') because I/O throttling can only be
set on the top layer, but BlockBackend always uses the coroutine
interface now instead of using the sync API emulation in block.c.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <1458660792-3035-2-git-send-email-kwolf@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
The same reasoning (at least the first part) applies to this patch.
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2017-09-20 13:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 11:43 [Qemu-devel] [PATCH 0/2] remove blk_pread_unthrottled() Manos Pitsidianakis
2017-09-20 11:43 ` [Qemu-devel] [PATCH 1/2] block/block-backend.c: add blk_check_byte_request call to blk_pread/blk_pwrite Manos Pitsidianakis
2017-09-20 12:24 ` Kevin Wolf
2017-09-20 14:35 ` Manos Pitsidianakis
2017-09-20 11:43 ` [Qemu-devel] [PATCH 2/2] block/block-backend.c: remove blk_pread_unthrottled() Manos Pitsidianakis
2017-09-20 12:37 ` Kevin Wolf [this message]
2017-09-20 20:10 ` John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170920123740.GE4730@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=el13635@mail.ntua.gr \
--cc=jsnow@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).