From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49028) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dugrR-0002vK-SC for qemu-devel@nongnu.org; Wed, 20 Sep 2017 11:24:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dugrN-0000Bh-7e for qemu-devel@nongnu.org; Wed, 20 Sep 2017 11:24:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52722) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dugrM-0000Ab-Ul for qemu-devel@nongnu.org; Wed, 20 Sep 2017 11:24:21 -0400 Date: Wed, 20 Sep 2017 17:24:13 +0200 From: Cornelia Huck Message-ID: <20170920172413.68b4c14f.cohuck@redhat.com> In-Reply-To: References: <20170919142654.16369-1-david@redhat.com> <20170920171458.0f6d88a3.cohuck@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 0/3] Implement basic MSA functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: David Hildenbrand Cc: qemu-devel@nongnu.org, Richard Henderson , thuth@redhat.com, Alexander Graf , Aurelien Jarno On Wed, 20 Sep 2017 17:17:33 +0200 David Hildenbrand wrote: > On 20.09.2017 17:14, Cornelia Huck wrote: > > On Tue, 19 Sep 2017 16:26:51 +0200 > > David Hildenbrand wrote: > > > >> Some leftover from "target/s390x: tcg improvments + MSA functions". > >> > >> Implement all basic MSA (cpacf/crypto) instructions <= z13. Only provide > >> the query subfunction (to query available subfunctions), no actual > >> de/encryption yet. Good enough to unlock the STFL bits. > >> > >> I have written kvm-unit-tests for MSA functions and for SPM/IPM. Will > >> send them out soon. I use the following cpu model to test with an upstream > >> kernel compiled for z10: > >> > >> ... -cpu qemu,mvcos=on,stfle=on,ldisp=on,ldisphp=on,\ > >> eimm=on,stckf=on,csst=on,csst2=on,ginste=on,\ > >> exrl=on,msa-base=on,msa3-base=on,msa4-base=on,msa5-base=on ... > >> > >> Based on: https://github.com/cohuck/qemu.git s390-next > >> Available on: https://github.com/davidhildenbrand/qemu.git s390x-msa > > > > Do I understand correctly that you'll send a v3 with changes to patch 3? > > > > If yes, I'll just wait and pick that. > > > > It is really just dropping one superfluous check in patch nr 3. > > So you can either fix that up or I can resend, whatever you prefer. > Please just resend before I start mucking around in patches again.