From: Manos Pitsidianakis <el13635@mail.ntua.gr>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>,
qemu-block <qemu-block@nongnu.org>, Kevin Wolf <kwolf@redhat.com>,
Max Reitz <mreitz@redhat.com>, Fam Zheng <famz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 1/3] block: add bdrv_co_drain_end callback
Date: Wed, 20 Sep 2017 20:32:10 +0300 [thread overview]
Message-ID: <20170920173210.ftursp2syk2vm3j5@postretch> (raw)
In-Reply-To: <20170920142632.GC9409@stefanha-x1.localdomain>
[-- Attachment #1: Type: text/plain, Size: 813 bytes --]
On Wed, Sep 20, 2017 at 03:26:32PM +0100, Stefan Hajnoczi wrote:
>On Wed, Sep 20, 2017 at 01:23:09PM +0300, Manos Pitsidianakis wrote:
>> @@ -188,7 +194,7 @@ static bool bdrv_drain_recurse(BlockDriverState *bs)
>> waited = BDRV_POLL_WHILE(bs, atomic_read(&bs->in_flight) > 0);
>>
>> /* Ensure any pending metadata writes are submitted to bs->file. */
>> - bdrv_drain_invoke(bs);
>> + bdrv_drain_invoke(bs, begin);
>
>Do you need to move bdrv_drain_invoke(bs, begin) before
>BDRV_POLL_WHILE(bs, atomic_read(&bs->in_flight) > 0)?
>
>This will ensure that throttling is disabled and the TGM restarted
>before we wait for requests to complete.
>
Hm yes. Before, the order was irrelevant because BlockBackend issued the
drain first by restarting the tgm in blk_root_drained_begin.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2017-09-20 17:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 10:23 [Qemu-devel] [PATCH 0/3] add bdrv_co_drain_begin/end BlockDriver callbacks Manos Pitsidianakis
2017-09-20 10:23 ` [Qemu-devel] [PATCH 1/3] block: add bdrv_co_drain_end callback Manos Pitsidianakis
2017-09-20 14:26 ` Stefan Hajnoczi
2017-09-20 17:32 ` Manos Pitsidianakis [this message]
2017-09-20 14:28 ` Stefan Hajnoczi
2017-09-20 10:23 ` [Qemu-devel] [PATCH 2/3] block: rename bdrv_co_drain to bdrv_co_drain_begin Manos Pitsidianakis
2017-09-20 14:28 ` Stefan Hajnoczi
2017-09-20 10:23 ` [Qemu-devel] [PATCH 3/3] block/throttle.c: add bdrv_co_drain_begin/end callbacks Manos Pitsidianakis
2017-09-20 14:26 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170920173210.ftursp2syk2vm3j5@postretch \
--to=el13635@mail.ntua.gr \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).