From: John Snow <jsnow@redhat.com>
To: qemu-block@nongnu.org
Cc: mark.cave-ayland@ilande.co.uk, qemu-devel@nongnu.org,
John Snow <jsnow@redhat.com>
Subject: [Qemu-devel] [PATCH 0/2] IDE: combine portio r/w functions
Date: Wed, 20 Sep 2017 21:20:35 -0400 [thread overview]
Message-ID: <20170921012037.553-1-jsnow@redhat.com> (raw)
Mark, here's a quick sketch for you. There are two things I don't like,
but didn't care enough to fix:
(1) Restricting nbytes to 2 or 4 means some extra boilerplate
to quiet compilers who don't know it will only ever be 2 or 4
(2) the address value is all-but-ignored, it carries over from the
portio signature and is useful primarily for tracing, but it's
a little ugly/deceiving to take a parameter and not use it.
Suggested-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
John Snow (2):
ide: generic ide_data_read
ide: generic ide_data_write
hw/ide/core.c | 185 +++++++++++++++++++++-------------------------
hw/ide/trace-events | 7 +-
include/hw/ide/internal.h | 4 +-
3 files changed, 89 insertions(+), 107 deletions(-)
--
2.9.5
next reply other threads:[~2017-09-21 1:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 1:20 John Snow [this message]
2017-09-21 1:20 ` [Qemu-devel] [PATCH 1/2] ide: generic ide_data_read John Snow
2017-09-21 1:20 ` [Qemu-devel] [PATCH 2/2] ide: generic ide_data_write John Snow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921012037.553-1-jsnow@redhat.com \
--to=jsnow@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).