From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57964) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duxjF-0005bH-Rg for qemu-devel@nongnu.org; Thu, 21 Sep 2017 05:25:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1duxjE-00044v-PT for qemu-devel@nongnu.org; Thu, 21 Sep 2017 05:25:05 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53066) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1duxjE-00043o-Jf for qemu-devel@nongnu.org; Thu, 21 Sep 2017 05:25:04 -0400 Date: Thu, 21 Sep 2017 11:24:59 +0200 From: Cornelia Huck Message-ID: <20170921112459.0153cc64.cohuck@redhat.com> In-Reply-To: <20170920172314.102710-1-pasic@linux.vnet.ibm.com> References: <20170920172314.102710-1-pasic@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] 3270 improvements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Halil Pasic Cc: Christian Borntraeger , Dong Jia Shi , Richard Henderson , Alexander Graf , "Jason J . Herne" , qemu-devel@nongnu.org On Wed, 20 Sep 2017 19:23:12 +0200 Halil Pasic wrote: > Jason found some problems with 3270 which he traced down to insufficient > output buffer size. I've looked into the underlying issue (and the > relevant code) and I saw strange things. Among others an unreasonable > assert requiring the payload of a ccw being less than some more or > less arbitrary limit (dictated by the size of the output buffer). > > Because we were already considering converting 3270 to CcwDataStream I've > decided to try do get rid of this strange limitation on the length of the > writes too. > > This series depends on my IDA work, which can be found here: > https://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg03434.html. > > Halil Pasic (2): > s390x/3270: IDA support for 3270 via CcwDataStream > s390x/3270: handle writes of arbitrary length > > hw/char/terminal3270.c | 46 +++++++++++++++++++++++++++------------------ > hw/s390x/3270-ccw.c | 4 ++-- > include/hw/s390x/3270-ccw.h | 5 ++--- > 3 files changed, 32 insertions(+), 23 deletions(-) > Are you planning to do some further work on 3270, btw?