From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49050) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1duz21-0004yD-3x for qemu-devel@nongnu.org; Thu, 21 Sep 2017 06:48:34 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1duz1x-00083b-Qs for qemu-devel@nongnu.org; Thu, 21 Sep 2017 06:48:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40936) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1duz1x-000826-Kb for qemu-devel@nongnu.org; Thu, 21 Sep 2017 06:48:29 -0400 Date: Thu, 21 Sep 2017 12:48:24 +0200 From: Cornelia Huck Message-ID: <20170921124824.5f613e26.cohuck@redhat.com> In-Reply-To: <8abd41f8-e3fd-682f-1669-a5c3870c32fd@linux.vnet.ibm.com> References: <20170920172314.102710-1-pasic@linux.vnet.ibm.com> <20170921112459.0153cc64.cohuck@redhat.com> <8abd41f8-e3fd-682f-1669-a5c3870c32fd@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] 3270 improvements List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Halil Pasic Cc: qemu-devel@nongnu.org, Alexander Graf , Christian Borntraeger , "Jason J . Herne" , Dong Jia Shi , Richard Henderson On Thu, 21 Sep 2017 12:22:30 +0200 Halil Pasic wrote: > On 09/21/2017 11:24 AM, Cornelia Huck wrote: > > On Wed, 20 Sep 2017 19:23:12 +0200 > > Halil Pasic wrote: > > > >> Jason found some problems with 3270 which he traced down to insufficient > >> output buffer size. I've looked into the underlying issue (and the > >> relevant code) and I saw strange things. Among others an unreasonable > >> assert requiring the payload of a ccw being less than some more or > >> less arbitrary limit (dictated by the size of the output buffer). > >> > >> Because we were already considering converting 3270 to CcwDataStream I've > >> decided to try do get rid of this strange limitation on the length of the > >> writes too. > >> > >> This series depends on my IDA work, which can be found here: > >> https://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg03434.html. > >> > >> Halil Pasic (2): > >> s390x/3270: IDA support for 3270 via CcwDataStream > >> s390x/3270: handle writes of arbitrary length > >> > >> hw/char/terminal3270.c | 46 +++++++++++++++++++++++++++------------------ > >> hw/s390x/3270-ccw.c | 4 ++-- > >> include/hw/s390x/3270-ccw.h | 5 ++--- > >> 3 files changed, 32 insertions(+), 23 deletions(-) > >> > > > > Are you planning to do some further work on 3270, btw? > > > > I did not. I jumped in because of IDA, and because I did > not agree with increasing the buffer size to another arbitrary > an value (and essentially keep the bug). I hope the original > authors will do further polishing. That was actually a plural 'you' (a pity that English uses the same word for both...) > > I'm just curious, what's behind the question? Just whether I can expect more 3270 changes in the future :) Things like support for multiple devices, whatever. Mostly curiousity.