From: Manos Pitsidianakis <el13635@mail.ntua.gr>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel <qemu-devel@nongnu.org>, Kevin Wolf <kwolf@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
qemu-block <qemu-block@nongnu.org>, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/3] add bdrv_co_drain_begin/end BlockDriver callbacks
Date: Thu, 21 Sep 2017 16:42:11 +0300 [thread overview]
Message-ID: <20170921134211.ilym353a3pmeilc4@postretch> (raw)
In-Reply-To: <20170921133535.GI13703@lemon.lan>
[-- Attachment #1: Type: text/plain, Size: 782 bytes --]
On Thu, Sep 21, 2017 at 09:35:35PM +0800, Fam Zheng wrote:
>On Thu, 09/21 16:17, Manos Pitsidianakis wrote:
>> This patch series renames bdrv_co_drain to bdrv_co_drain_begin and adds a new
>> bdrv_co_drain_end callback to match bdrv_drained_begin/end and
>> drained_begin/end of BdrvChild. This is needed because the throttle driver
>> (block/throttle.c) needs a way to mark the end of the drain in order to toggle
>> io_limits_disabled correctly.
>
>Is this a bug fix? I.e. do we need to Cc qemu-stable@?
>
>Fam
No that's not needed, throttle is not in 2.10. The bug in this case is
that the drain would wait for the throttled requests to be completed as
they were scheduled by the I/O throttling instead of restarting the
queue and scheduling them right away.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2017-09-21 13:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 13:17 [Qemu-devel] [PATCH v2 0/3] add bdrv_co_drain_begin/end BlockDriver callbacks Manos Pitsidianakis
2017-09-21 13:17 ` [Qemu-devel] [PATCH v2 1/3] block: add bdrv_co_drain_end callback Manos Pitsidianakis
2017-09-21 13:29 ` Fam Zheng
2017-09-21 15:39 ` Manos Pitsidianakis
2017-09-22 2:30 ` Fam Zheng
2017-09-22 11:03 ` Kevin Wolf
2017-09-22 12:34 ` Fam Zheng
2017-09-21 13:30 ` Fam Zheng
2017-09-21 13:17 ` [Qemu-devel] [PATCH v2 2/3] block: rename bdrv_co_drain to bdrv_co_drain_begin Manos Pitsidianakis
2017-09-21 13:30 ` Fam Zheng
2017-09-21 13:17 ` [Qemu-devel] [PATCH v2 3/3] block/throttle.c: add bdrv_co_drain_begin/end callbacks Manos Pitsidianakis
2017-09-21 13:31 ` Fam Zheng
2017-09-22 10:18 ` Stefan Hajnoczi
2017-09-21 13:35 ` [Qemu-devel] [PATCH v2 0/3] add bdrv_co_drain_begin/end BlockDriver callbacks Fam Zheng
2017-09-21 13:42 ` Manos Pitsidianakis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170921134211.ilym353a3pmeilc4@postretch \
--to=el13635@mail.ntua.gr \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).