Re: [Qemu-devel] [RFC PATCH] qdev: Mark devices as non-hotpluggable by default

[Anthony PERARD <anthony.perard@citrix.com>]

On Tue, Sep 19, 2017 at 10:55:53AM +0200, Thomas Huth wrote:
> Historically we've marked all devices as hotpluggable by default. However,
> most devices are not hotpluggable, and you also need a HotplugHandler to
> support these devices. So if the user tries to "device_add" or "device_del"
> such a non-hotpluggable device during runtime, either nothing really usable
> happens, or QEMU even crashes/aborts unexpectedly (see for example commit
> 84ebd3e8c7d4fe955b - "Mark diag288 watchdog as non-hotpluggable").
> So let's change this dangerous default behaviour and mark the devices as
> non-hotpluggable by default. Certain parent devices classes which are known
> as hotpluggable (e.g. PCI, USB, etc.) are marked with "hotpluggable = true",
> so that devices that are derived from these classes continue to work as
> expected.
> 
> Signed-off-by: Thomas Huth <thuth@redhat.com>


Hi,

xen-backend is needed to be hotpluggable, otherwise I have this error
message:
qemu-system-i386: Initialization of device xen-backend failed: Device 'xen-backend' does not support hotplugging

Also, when I try to add more cpus:
QMP command: { "execute": "cpu-add", "id": 2, "arguments": { "id": 2 } }
error message: Device 'qemu32-i386-cpu' does not support hotplugging


I've tested all I could think of that would involve hotplug.

Thanks,

-- 
Anthony PERARD