qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Eduardo Habkost" <ehabkost@redhat.com>,
	qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
	"Philippe Mathieu-Daudé" <f4bug@amsat.org>
Subject: Re: [Qemu-devel] [PATCH] MAINTAINERS: Fix subsystem name for "Build and test automation"
Date: Fri, 22 Sep 2017 11:30:26 +0800	[thread overview]
Message-ID: <20170922033026.GE1397@lemon.lan> (raw)
In-Reply-To: <7ad0e182-536b-42d8-5b80-bfcd03612a00@redhat.com>

On Fri, 09/22 05:14, Thomas Huth wrote:
> On 21.09.2017 19:02, Eduardo Habkost wrote:
> > The subsystem name for the "Build test automation" section is
> > "-------------------------", because an actual subsystem name
> > line is missing:
> > 
> >   $ ./scripts/get_maintainer.pl -f tests/docker/docker.py
> >   "Alex Bennée" <alex.bennee@linaro.org> (maintainer:-----------------...)
> >   Fam Zheng <famz@redhat.com> (maintainer:-----------------...)
> >   "Philippe Mathieu-Daudé" <f4bug@amsat.org> (reviewer:-----------------...)
> >   qemu-devel@nongnu.org (open list:-----------------...)
> > 
> > Fix the issue by inserting a subsystem name line where
> > get_maintainer.pl expects it.
> > 
> > Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
> > ---
> >  MAINTAINERS | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index e511ba780f..13c1ac65b7 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1896,6 +1896,7 @@ F: docs/block-replication.txt
> >  
> >  Build and test automation
> >  -------------------------
> > +Build and test automation
> 
> Would it make sense to use something more specific here? Like "Travis
> and Docker" or so? ... in case we add other subsections in the future?

Unless we are to split off (i.e. more people volunteering maintaining a certain
subset), the list will just go on and on in this line. For not it's already
going to be "Travis, Shippable, Docker and VM test".. so I think a generic
description here is okay, though the duplication is a bit odd (but I don't have
a better idea).

Fam

  reply	other threads:[~2017-09-22  3:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-21 17:02 [Qemu-devel] [PATCH] MAINTAINERS: Fix subsystem name for "Build and test automation" Eduardo Habkost
2017-09-22  2:21 ` Fam Zheng
2017-09-22  3:14 ` Thomas Huth
2017-09-22  3:30   ` Fam Zheng [this message]
2017-09-22 21:02     ` Eric Blake
2017-09-25  2:37       ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170922033026.GE1397@lemon.lan \
    --to=famz@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=ehabkost@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).