qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: [Qemu-devel] [PULL 07/36] tests/docker: Clean up paths
Date: Fri, 22 Sep 2017 15:46:30 +0800	[thread overview]
Message-ID: <20170922074659.30097-8-famz@redhat.com> (raw)
In-Reply-To: <20170922074659.30097-1-famz@redhat.com>

The 'run' script already creats src, build and install directories under
$TEST_DIR, use it in common.rc.

Also the tests always run from $QEMU_SRC/tests/docker, so use a relative
$CMD string.

Message-Id: <20170817035721.11064-1-famz@redhat.com>
Signed-off-by: Fam Zheng <famz@redhat.com>
---
 tests/docker/common.rc | 5 +----
 tests/docker/run       | 4 +++-
 2 files changed, 4 insertions(+), 5 deletions(-)

diff --git a/tests/docker/common.rc b/tests/docker/common.rc
index 6865689bb5..64b36ba2d0 100755
--- a/tests/docker/common.rc
+++ b/tests/docker/common.rc
@@ -11,9 +11,6 @@
 # or (at your option) any later version. See the COPYING file in
 # the top-level directory.
 
-BUILD_DIR=/var/tmp/qemu-build
-mkdir $BUILD_DIR
-
 requires()
 {
     for c in $@; do
@@ -28,7 +25,7 @@ build_qemu()
 {
     config_opts="--enable-werror \
                  ${TARGET_LIST:+--target-list=${TARGET_LIST}} \
-                 --prefix=$PWD/install \
+                 --prefix=$INSTALL_DIR \
                  $QEMU_CONFIGURE_OPTS $EXTRA_CONFIGURE_OPTS \
                  $@"
     echo "Configure options:"
diff --git a/tests/docker/run b/tests/docker/run
index c1e4513bce..ec2541cbd9 100755
--- a/tests/docker/run
+++ b/tests/docker/run
@@ -52,10 +52,12 @@ if test -n "$SHOW_ENV"; then
 fi
 
 export QEMU_SRC="$TEST_DIR/src"
+export BUILD_DIR="$TEST_DIR/build"
+export INSTALL_DIR="$TEST_DIR/install"
 
 cd "$QEMU_SRC/tests/docker"
 
-CMD="$QEMU_SRC/tests/docker/$@"
+CMD="./$@"
 
 if test -z "$DEBUG"; then
     exec $CMD
-- 
2.13.5

  parent reply	other threads:[~2017-09-22  7:47 UTC|newest]

Thread overview: 40+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-22  7:46 [Qemu-devel] [PULL v5 00/36] Build and test automation patches Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 01/36] docker: ensure NOUSER for travis images Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 02/36] docker: docker.py make --no-cache skip checksum test Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 03/36] docker: don't install device-tree-compiler build-deps in travis.docker Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 04/36] docker: reduce noise when building travis.docker Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 05/36] docker: Update ubuntu image Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 06/36] docker: Enable features explicitly in test-full Fam Zheng
2017-10-02 14:21   ` Paolo Bonzini
2017-10-18  8:09     ` Fam Zheng
2017-09-22  7:46 ` Fam Zheng [this message]
2017-09-22  7:46 ` [Qemu-devel] [PULL 08/36] docker: Fix return code of build_qemu() Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 09/36] docker: Add test_fail and prep_fail Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 10/36] docker: Use unconfined security profile Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 11/36] docker: Add nettle-devel to fedora image Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 12/36] docker: Add test-block Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 13/36] vl: Don't include vde header Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 14/36] buildsys: Move vde libs to per object Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 15/36] buildsys: Move sdl cflags/libs " Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 16/36] buildsys: Move audio libs " Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 17/36] buildsys: Move libcacard cflags/libs " Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 18/36] buildsys: Move libusb " Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 19/36] buildsys: Move usb redir " Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 20/36] buildsys: Move brlapi libs " Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 21/36] buildsys: Move rdma " Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 22/36] MAINTAINERS: Fix subsystem name for "Build and test automation" Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 23/36] gitignore: Ignore vm test images Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 24/36] qemu.py: Add "wait()" method Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 25/36] scripts: Add archive-source.sh Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 26/36] tests: Add a test key pair Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 27/36] tests: Add vm test lib Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 28/36] tests: Add ubuntu.i386 image Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 29/36] tests: Add FreeBSD image Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 30/36] tests: Add NetBSD image Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 31/36] tests: Add OpenBSD image Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 32/36] Makefile: Add rules to run vm tests Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 33/36] MAINTAINERS: Add tests/vm entry Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 34/36] tests: Add README for vm tests Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 35/36] docker: Use archive-source.py Fam Zheng
2017-09-22  7:46 ` [Qemu-devel] [PULL 36/36] docker: Drop 'set -e' from run script Fam Zheng
2017-09-22 11:55 ` [Qemu-devel] [PULL v5 00/36] Build and test automation patches Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170922074659.30097-8-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).