From: Peter Xu <peterx@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org,
"Daniel P . Berrange" <berrange@redhat.com>,
"Eric Blake" <eblake@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Juan Quintela" <quintela@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 3/4] chardev: use per-dev context for io_add_watch_poll
Date: Fri, 22 Sep 2017 17:18:15 +0800 [thread overview]
Message-ID: <20170922091815.GK30661@pxdev.xzpeter.org> (raw)
In-Reply-To: <f64bbc56-4f0d-7cc0-b62c-23045f33ad78@redhat.com>
On Thu, Sep 21, 2017 at 04:11:33PM +0200, Paolo Bonzini wrote:
> On 21/09/2017 08:35, Peter Xu wrote:
> > It was only passed in by chr_update_read_handlers(). However when
> > reconnect, we'll lose that context information. So if a chardev was
> > running on another context (rather than the default context, the NULL
> > pointer), it'll switch back to the default context if reconnection
> > happens. But, it should really stick to the old context.
> >
> > Convert all the callers of io_add_watch_poll() to use the internally
> > cached gcontext. Then the context should be able to survive even after
> > reconnections.
>
> Why keep the argument then?
Yeah it's in next patch. I see that this series has been queued
already. Thanks!
--
Peter Xu
next prev parent reply other threads:[~2017-09-22 9:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 6:35 [Qemu-devel] [PATCH v2 0/4] chardev: support non-default gcontext Peter Xu
2017-09-21 6:35 ` [Qemu-devel] [PATCH v2 1/4] chardev: new qemu_chr_be_update_read_handlers() Peter Xu
2017-09-21 6:35 ` [Qemu-devel] [PATCH v2 2/4] chardev: add Chardev.gcontext field Peter Xu
2017-09-21 6:35 ` [Qemu-devel] [PATCH v2 3/4] chardev: use per-dev context for io_add_watch_poll Peter Xu
2017-09-21 14:11 ` Paolo Bonzini
2017-09-22 9:18 ` Peter Xu [this message]
2017-09-21 6:35 ` [Qemu-devel] [PATCH v2 4/4] chardev: remove context in chr_update_read_handler Peter Xu
2017-09-21 12:05 ` [Qemu-devel] [PATCH v2 0/4] chardev: support non-default gcontext Marc-André Lureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922091815.GK30661@pxdev.xzpeter.org \
--to=peterx@redhat.com \
--cc=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).