From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51772) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvL51-0007ca-Bd for qemu-devel@nongnu.org; Fri, 22 Sep 2017 06:21:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvL4y-0007Gr-NP for qemu-devel@nongnu.org; Fri, 22 Sep 2017 06:21:07 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33154) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dvL4y-0007G0-Ga for qemu-devel@nongnu.org; Fri, 22 Sep 2017 06:21:04 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 922EE20271 for ; Fri, 22 Sep 2017 10:21:03 +0000 (UTC) Date: Fri, 22 Sep 2017 11:20:49 +0100 From: "Daniel P. Berrange" Message-ID: <20170922102049.GK12725@redhat.com> Reply-To: "Daniel P. Berrange" References: <1506070572-7549-1-git-send-email-peterx@redhat.com> <1506070572-7549-2-git-send-email-peterx@redhat.com> <20170922101652.GF9243@stefanha-x1.localdomain> <4bf59c2a-8b21-0613-5575-3dfee2762633@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <4bf59c2a-8b21-0613-5575-3dfee2762633@redhat.com> Subject: Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Stefan Hajnoczi , Markus Armbruster , qemu-devel@nongnu.org, Stefan Hajnoczi , Fam Zheng , "Dr . David Alan Gilbert" , Peter Xu On Fri, Sep 22, 2017 at 12:18:44PM +0200, Paolo Bonzini wrote: > On 22/09/2017 12:16, Stefan Hajnoczi wrote: > > I suggest adding internal IOThreads alongside user-created IOThreads > > instead of hiding them. IOThread also needs a bool user_created field > > and a UserCreatableClass->can_be_deleted() function: > > > > static bool iothread_can_be_deleted(UserCreatable *uc) > > { > > return IOTHREAD(uc)->user_created; > > } > > > > This way users cannot delete internal IOThreads. > > > > But how should object ids be handled? In theory existing -object > > iothread,id= users could use any name. How can QEMU generate ids > > for internal IOThreads without conflicting with existing users's ids? > > I would add an 'internal' boolean to query-iothreads' response and a new > 'show-internal' boolean to the command. This way, applications that > request internal iothreads would know that the "primary key" is > (internal, id) rather than just the id. What is the app going to do with iothreads if it sees "internal" flag set ? They have no way of knowing what part of QEMU internally is using this iothread, so I don't see that they can do anything intelligent once they find out they exist. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|