From: Stefan Hajnoczi <stefanha@redhat.com>
To: Peter Lieven <pl@kamp.de>
Cc: qemu-devel@nongnu.org, quintela@redhat.com, famz@redhat.com,
dgilbert@redhat.com, pbonzini@redhat.com, qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] migration: disable auto-converge during bulk block migration
Date: Fri, 22 Sep 2017 11:22:51 +0100 [thread overview]
Message-ID: <20170922102251.GH9243@stefanha-x1.localdomain> (raw)
In-Reply-To: <1505997152-16980-1-git-send-email-pl@kamp.de>
On Thu, Sep 21, 2017 at 02:32:32PM +0200, Peter Lieven wrote:
> auto-converge and block migration currently do not play well together.
> During block migration the auto-converge logic detects that ram
> migration makes no progress and thus throttles down the vm until
> it nearly stalls completely. Avoid this by disabling the throttling
> logic during the bulk phase of the block migration.
Please include the rationale in a comment here:
> - if (migrate_auto_converge()) {
> + if (migrate_auto_converge() && !blk_mig_bulk_active()) {
That way it's clear why auto-converge isn't enabled when block migration
is active.
next prev parent reply other threads:[~2017-09-22 10:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-21 12:32 [Qemu-devel] [PATCH] migration: disable auto-converge during bulk block migration Peter Lieven
2017-09-22 10:22 ` Stefan Hajnoczi [this message]
2017-09-25 20:53 ` [Qemu-devel] [Qemu-stable] " Michael Roth
2017-09-26 10:19 ` Peter Lieven
2017-09-28 12:04 ` Peter Lieven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170922102251.GH9243@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=dgilbert@redhat.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).