From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43489) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dvMWh-0002Dr-R1 for qemu-devel@nongnu.org; Fri, 22 Sep 2017 07:53:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dvMWc-0006p8-Vh for qemu-devel@nongnu.org; Fri, 22 Sep 2017 07:53:47 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58212) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dvMWc-0006oq-M9 for qemu-devel@nongnu.org; Fri, 22 Sep 2017 07:53:42 -0400 Date: Fri, 22 Sep 2017 12:53:35 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20170922115334.GI2620@work-vm> References: <1504081950-2528-1-git-send-email-peterx@redhat.com> <1504081950-2528-26-git-send-email-peterx@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1504081950-2528-26-git-send-email-peterx@redhat.com> Subject: Re: [Qemu-devel] [RFC v2 25/33] migration: setup ramstate for resume List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Xu Cc: qemu-devel@nongnu.org, Laurent Vivier , "Daniel P . Berrange" , Alexey Perevalov , Juan Quintela , Andrea Arcangeli * Peter Xu (peterx@redhat.com) wrote: > After we updated the dirty bitmaps of ramblocks, we also need to update > the critical fields in RAMState to make sure it is ready for a resume. > > Signed-off-by: Peter Xu > --- > migration/ram.c | 37 ++++++++++++++++++++++++++++++++++++- > migration/trace-events | 1 + > 2 files changed, 37 insertions(+), 1 deletion(-) > > diff --git a/migration/ram.c b/migration/ram.c > index afabcf5..c5d9028 100644 > --- a/migration/ram.c > +++ b/migration/ram.c > @@ -1986,6 +1986,33 @@ static int ram_state_init(RAMState **rsp) > return 0; > } > > +static void ram_state_resume_prepare(RAMState *rs) > +{ > + RAMBlock *block; > + long pages = 0; > + > + /* > + * Postcopy is not using xbzrle/compression, so no need for that. > + * Also, since source are already halted, we don't need to care > + * about dirty page logging as well. > + */ > + > + RAMBLOCK_FOREACH(block) { > + pages += bitmap_count_one(block->bmap, > + block->used_length >> TARGET_PAGE_BITS); > + } > + > + /* This may not be aligned with current bitmaps. Recalculate. */ > + rs->migration_dirty_pages = pages; > + > + rs->last_seen_block = NULL; > + rs->last_sent_block = NULL; > + rs->last_page = 0; > + rs->last_version = ram_list.version; > + > + trace_ram_state_resume_prepare(pages); Yes, I think this is fine; I wonder what happens if pages is 0? However, Reviewed-by: Dr. David Alan Gilbert > +} > + > /* > * Each of ram_save_setup, ram_save_iterate and ram_save_complete has > * long-running RCU critical section. When rcu-reclaims in the code > @@ -2909,8 +2936,16 @@ out: > static int ram_resume_prepare(MigrationState *s, void *opaque) > { > RAMState *rs = *(RAMState **)opaque; > + int ret; > > - return ram_dirty_bitmap_sync_all(s, rs); > + ret = ram_dirty_bitmap_sync_all(s, rs); > + if (ret) { > + return ret; > + } > + > + ram_state_resume_prepare(rs); > + > + return 0; > } > > static SaveVMHandlers savevm_ram_handlers = { > diff --git a/migration/trace-events b/migration/trace-events > index 8962916..6e06283 100644 > --- a/migration/trace-events > +++ b/migration/trace-events > @@ -85,6 +85,7 @@ ram_dirty_bitmap_sync_start(void) "" > ram_dirty_bitmap_sync_wait(void) "" > ram_dirty_bitmap_sync_notify(void) "" > ram_dirty_bitmap_sync_complete(void) "" > +ram_state_resume_prepare(long v) "%ld" > > # migration/migration.c > await_return_path_close_on_source_close(void) "" > -- > 2.7.4 > > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK