qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Juergen Gross <jgross@suse.com>
To: qemu-devel@nongnu.org, xen-devel@lists.xenproject.org
Cc: anthony.perard@citrix.com, kraxel@redhat.com,
	sstabellini@kernel.org, Juergen Gross <jgross@suse.com>
Subject: [Qemu-devel] [PATCH v2 0/2] xen: fix gnttab handling with old dom0 kernels
Date: Fri, 22 Sep 2017 14:07:23 +0200	[thread overview]
Message-ID: <20170922120725.10910-1-jgross@suse.com> (raw)

Trying to start a domain with a qdisk backend on an old dom0 kernel
(non-pvops xen kernel) will fail as xengnttab_set_max_grants() will
succeed only if called directly after opening the gnttab device.

These two patches address the issue by:

- moving the test for availability of xengnttab_grant_copy() from
  the qdisk backend to generic backend handling in order to not have
  to issue the grant copy ioctl with the qdisk specific file handle
- opening the gnttab device in blk_connect() only in order to
  guarantee xengnttab_set_max_grants() is called just after opening
  the gnttab device

Juergen Gross (2):
  xen: add a global indicator for grant copy being available
  xen: dont try setting max grants multiple times

 hw/block/xen_disk.c          | 34 ++++++++++++++++++----------------
 hw/xen/xen_backend.c         | 11 +++++++++++
 include/hw/xen/xen_backend.h |  1 +
 3 files changed, 30 insertions(+), 16 deletions(-)

-- 
2.12.3

             reply	other threads:[~2017-09-22 12:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-22 12:07 Juergen Gross [this message]
2017-09-22 12:07 ` [Qemu-devel] [PATCH v2 1/2] xen: add a global indicator for grant copy being available Juergen Gross
2017-09-22 12:07 ` [Qemu-devel] [PATCH v2 2/2] xen: dont try setting max grants multiple times Juergen Gross
2017-09-25 14:41   ` Anthony PERARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170922120725.10910-1-jgross@suse.com \
    --to=jgross@suse.com \
    --cc=anthony.perard@citrix.com \
    --cc=kraxel@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).